Push UI updates #5488
Draft
Push UI updates #5488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ PS. Pls add /docs/nightly to the end of url
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ PS. Pls add /docs/nightly to the end of url
To edit notification comments on pull requests, go to your Netlify site configuration. |
letzya
force-pushed
the
editing-UI-new-IA
branch
from
65fe29b
to
93566f5
Compare
…s/tyk-docs into editing-UI-new-IA Update the UI to avoid errors
sharadregoti
requested changes
Oct 3, 2024
| } else if ( $('.active').hasClass('st-file') && $('.active').closest('.st-open').length === 0) { | ||
| if(currentPageGH == '/docs'){ | ||
| window.open("https://github.com/TykTechnologies/tyk-docs/tree/master/tyk-docs/content/documentation.md", "_blank"); | ||
| window.open("https://github.com/TykTechnologies/tyk-docs/tree/master/tyk-docsdocumentation.md", "_blank"); |
There was a problem hiding this comment.
Suggested change
| window.open("https://github.com/TykTechnologies/tyk-docs/tree/master/tyk-docsdocumentation.md", "_blank"); | |
| window.open("https://github.com/TykTechnologies/tyk-docs/tree/master/tyk-docs/documentation.md", "_blank"); |
|
@DavidRollins . One ui issue.The left navigation is too squeezed (the width seems too small)
|
buger
reviewed
Oct 8, 2024
| height: 100%; | ||
| } | ||
|
|
||
| .toc-label { | ||
| toc-label { |
There was a problem hiding this comment.
Was the goal to just disable those styles, by removing the dot?
letzya
reviewed
Oct 15, 2024
| padding-right: 50px; | ||
| padding-top: 62px; | ||
| padding-bottom: 85px; | ||
| padding-left: 20px; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For internal users - Please add a Jira DX PR ticket to the subject!
Preview Link
https://deploy-preview-5488--tyk-docs.netlify.app/docs/nightly/getting-started/quick-start/
Description
2. Please explain the change to the reviewer. Pay special attention to changes that are hard to spot,
for example:
2.1. Updating menu.yaml file to new IA structure, should not lose any content from master.
2.2. Updating html, css, and js objects to fix mobile platform and UI for new IA.
3. @mentions of the person to review the proposed changes. They need to be able to know the topic well in order to approve it.
Screenshots (if appropriate)
Checklist
master.