-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Push UI updates #5488
base: master
Are you sure you want to change the base?
Push UI updates #5488
Conversation
✅ PS. Pls add /docs/nightly to the end of url
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ PS. Pls add /docs/nightly to the end of url
To edit notification comments on pull requests, go to your Netlify site configuration. |
65fe29b
to
93566f5
Compare
…s/tyk-docs into editing-UI-new-IA Update the UI to avoid errors
} else if ( $('.active').hasClass('st-file') && $('.active').closest('.st-open').length === 0) { | ||
if(currentPageGH == '/docs'){ | ||
window.open("https://github.com/TykTechnologies/tyk-docs/tree/master/tyk-docs/content/documentation.md", "_blank"); | ||
window.open("https://github.com/TykTechnologies/tyk-docs/tree/master/tyk-docsdocumentation.md", "_blank"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
window.open("https://github.com/TykTechnologies/tyk-docs/tree/master/tyk-docsdocumentation.md", "_blank"); | |
window.open("https://github.com/TykTechnologies/tyk-docs/tree/master/tyk-docs/documentation.md", "_blank"); |
@DavidRollins . One ui issue.The left navigation is too squeezed (the width seems too small) |
height: 100%; | ||
} | ||
|
||
.toc-label { | ||
toc-label { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was the goal to just disable those styles, by removing the dot?
padding-right: 50px; | ||
padding-top: 62px; | ||
padding-bottom: 85px; | ||
padding-left: 20px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we've done that
For internal users - Please add a Jira DX PR ticket to the subject!
Preview Link
https://deploy-preview-5488--tyk-docs.netlify.app/docs/nightly/getting-started/quick-start/
Description
2. Please explain the change to the reviewer. Pay special attention to changes that are hard to spot,
for example:
2.1. Updating menu.yaml file to new IA structure, should not lose any content from master.
2.2. Updating html, css, and js objects to fix mobile platform and UI for new IA.
3. @mentions of the person to review the proposed changes. They need to be able to know the topic well in order to approve it.
Screenshots (if appropriate)
Checklist
master
.