TT 3695 - Fix Security Policy Migration

[buraksekili]

Description

The migration steps described in this documentation do not work as expected. Setting the id field in the CR to the _id field of the existing Policy has some issues.

Related Issue

Resolves #204
https://tyktech.atlassian.net/browse/TT-3695

Motivation and Context

Once you migrate the existing policy from Dashboard to k8s, k8s state should include details of the spec that exists on Dashboard, and from now on, the source of truth must become k8s. Operator must restore subsequent changes from Dashboard in the next reconciliations.

Test Coverage For This Change

Added test cases to cover:

• Migration of an existing Security Policy from Dashboard to k8s
• Ensuring k8s is the source of truth.
  • Drifts (updates/deletes) from Dashboard should be restored based on the k8s state in the next reconciliation.
• Creating a simple SecurityPolicy should update ApiDefinition's status if that SecurityPolicy refers to it
  • Ensure that corresponding resources are created on Tyk
• Deleting this SecurityPolicy must update ApiDefinition status.
  • Ensure that the corresponding SecurityPolicy is deleted from Tyk as well

Screenshots (if appropriate)

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If PRing from your fork, don't come from your master!
• Make sure you are making a pull request against our master branch (left side). Also, it would be best if you started your change off our latest master.
• Make sure you are updating CHANGELOG.md based on your changes.
• My change requires a change to the documentation.
  • If you've changed APIs, describe what needs to be updated in the documentation.
• I have updated the documentation accordingly.
• If you've changed API models, please update CRDs.
  • make manifests
  • make helm
• I have added tests to cover my changes.
• All new and existing tests passed.
• Check your code additions will not fail linting checks:
  • gofmt -s -w .
  • go vet ./...
  • golangci-lint run

[komalsukhani]

@buraksekili Thank you for resolving this complicated bug! It looks good to me.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

0.0% Coverage
0.0% Duplication