This repository has been archived by the owner on Oct 11, 2024. It is now read-only.
Feat/basic auth contribution #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/basic_auth_contribution
…yk.tyk.io_apidefinitions.yaml and helm/crds/crds.yaml.
buraksekili
approved these changes
Dec 15, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
buger
pushed a commit
that referenced
this pull request
May 22, 2024
* Add basic authentication option with default settings * Ran "make manifests" and "make helm" to update the config/crd/bases/tyk.tyk.io_apidefinitions.yaml and helm/crds/crds.yaml. Co-authored-by: Bogumil_Laska <bogumil_laska@epam.com> Co-authored-by: Burak Sekili <buraksekili@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added changes implemented in PR #539 and ran the required commands needed for CRDs documentation update.
To help with testing, apply the provided sample for basic-auth, create a basic auth key in the dashboard, port forward the gateway endpoint and use a command similar to curl http://localhost:8080/httpbin/headers -u "exampleUser:123456".
Without the user created we should get "User not authorised", with it created we should get the normal response.
Related Issue
Motivation and Context
Test Coverage For This Change
Screenshots (if appropriate)
Types of changes
Checklist
master!masterbranch (left side). Also, it would be best if you started your change off our latestmaster.make manifestsmake helmgofmt -s -w .go vet ./...golangci-lint run