This repository has been archived by the owner on Oct 11, 2024. It is now read-only.
TT-8124 Replace curl requests with k8s port-forwards #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Burak Sekili <buraksekili@gmail.com>
Signed-off-by: Burak Sekili <buraksekili@gmail.com>
Signed-off-by: Burak Sekili <buraksekili@gmail.com>
buraksekili
changed the title
Signed-off-by: Burak Sekili <buraksekili@gmail.com>
andrei-tyk
approved these changes
Feb 24, 2023
Signed-off-by: Burak Sekili <buraksekili@gmail.com>
|
Kudos, SonarCloud Quality Gate passed! |
buger
pushed a commit
that referenced
this pull request
May 22, 2024
* Replace curl requests with k8s port-forwards Signed-off-by: Burak Sekili <buraksekili@gmail.com> * Open connection in init function Signed-off-by: Burak Sekili <buraksekili@gmail.com> * Update changelog Signed-off-by: Burak Sekili <buraksekili@gmail.com> * Update typo in http method Signed-off-by: Burak Sekili <buraksekili@gmail.com> * Revert typo fix Signed-off-by: Burak Sekili <buraksekili@gmail.com> --------- Signed-off-by: Burak Sekili <buraksekili@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With recent chances, Gateway images do not contain
curlbinary. In the bdd tests, we usecurlin GW containers to send requests to gw. Therefore, CI was failing due to unknown binary.This PR updates bdd tests to use port-forward instead of executing
curlwithin a container.Related Issue
Motivation and Context
Test Coverage For This Change
Screenshots (if appropriate)
Types of changes
Checklist
master!masterbranch (left side). Also, it would be best if you started your change off our latestmaster.make manifestsmake helmgofmt -s -w .go vet ./...golangci-lint run