Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

TT-6389 - Cover reconciliation of nonexistent ApiDefinitions in integration tests #575

Merged
merged 1 commit into from
Feb 28, 2023
Merged

TT-6389 - Cover reconciliation of nonexistent ApiDefinitions in integration tests #575

merged 1 commit into from
Feb 28, 2023

Conversation

buraksekili
Copy link
Collaborator

@buraksekili buraksekili commented Feb 27, 2023 •
edited
Loading

Description

Add test cases to cover reconciliation of nonexistent ApiDefinitions.
Refactor existing tests and helper methods, add comments and move all common variables to constants.

Related Issue

Motivation and Context

Test Coverage For This Change

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If PRing from your fork, don't come from your master!
  • Make sure you are making a pull request against our master branch (left side). Also, it would be best if you started your change off our latest master.
  • Make sure you are updating CHANGELOG.md based on your changes.
  • My change requires a change to the documentation.
    • If you've changed APIs, describe what needs to be updated in the documentation.
  • I have updated the documentation accordingly.
  • If you've changed API models, please update CRDs.
    • make manifests
    • make helm
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Check your code additions will not fail linting checks:
    • gofmt -s -w .
    • go vet ./...
    • golangci-lint run

@buraksekili
Add a new test case to cover whether reconciliation covers creation of
03d2ced 
nonexistent ApiDefinitions.
Refactor existing tests and helper methods, add comments and move all
common variables to constants.

Signed-off-by: Burak Sekili <buraksekili@gmail.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@buraksekili buraksekili marked this pull request as ready for review February 27, 2023 20:10
@buraksekili buraksekili requested a review from a team as a code owner February 27, 2023 20:10
@buraksekili buraksekili requested review from andrei-tyk and removed request for a team February 27, 2023 20:10
@buraksekili buraksekili changed the title Cover reconciliation of nonexistent ApiDefinitions in integration tests TT-7610 - Cover reconciliation of nonexistent ApiDefinitions in integration tests Feb 28, 2023
@buraksekili buraksekili changed the title TT-7610 - Cover reconciliation of nonexistent ApiDefinitions in integration tests TT-6389 - Cover reconciliation of nonexistent ApiDefinitions in integration tests Feb 28, 2023
@buraksekili buraksekili merged commit c285627 into master Feb 28, 2023
@buraksekili buraksekili deleted the refactor/enhance-test-cases branch February 28, 2023 11:41
buger pushed a commit that referenced this pull request May 22, 2024
@buraksekili
Add a new test case to cover whether reconciliation covers creation of (
507e955 
#575)

nonexistent ApiDefinitions.
Refactor existing tests and helper methods, add comments and move all
common variables to constants.

Signed-off-by: Burak Sekili <buraksekili@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrei-tyk andrei-tyk andrei-tyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@buraksekili @andrei-tyk