This repository has been archived by the owner on Oct 11, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Burak Sekili <buraksekili@gmail.com>
Signed-off-by: Burak Sekili <buraksekili@gmail.com>
Signed-off-by: Burak Sekili <buraksekili@gmail.com>
Signed-off-by: Burak Sekili <buraksekili@gmail.com>
Signed-off-by: Burak Sekili <buraksekili@gmail.com>
caroltyk
reviewed
Feb 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating this! Just a small change suggested
Co-authored-by: caroltyk <97617859+caroltyk@users.noreply.github.com>
Signed-off-by: Burak Sekili <buraksekili@gmail.com>
… feat/contribution-guideline
…ies/tyk-operator into feat/contribution-guideline
Kudos, SonarCloud Quality Gate passed!
|
caroltyk
approved these changes
Mar 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks
buger
pushed a commit
that referenced
this pull request
May 22, 2024
* Add CONTRIBUTING guideline and update development documentation Signed-off-by: Burak Sekili <buraksekili@gmail.com> * Add contributing guideline ref to README Signed-off-by: Burak Sekili <buraksekili@gmail.com> * Update header of CE installation doc Signed-off-by: Burak Sekili <buraksekili@gmail.com> * Update summary output Signed-off-by: Burak Sekili <buraksekili@gmail.com> * Update header link based on github conventions Signed-off-by: Burak Sekili <buraksekili@gmail.com> * Update CONTRIBUTING.md Co-authored-by: caroltyk <97617859+caroltyk@users.noreply.github.com> * Update development guide Signed-off-by: Burak Sekili <buraksekili@gmail.com> --------- Signed-off-by: Burak Sekili <buraksekili@gmail.com> Co-authored-by: caroltyk <97617859+caroltyk@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a contributing guideline for Tyk Operator. Also, it updates local development documentation.
Related Issue
Motivation and Context
Test Coverage For This Change
Screenshots (if appropriate)
Types of changes
Checklist
master
!master
branch (left side). Also, it would be best if you started your change off our latestmaster
.make manifests
make helm
gofmt -s -w .
go vet ./...
golangci-lint run