This repository has been archived by the owner on Oct 11, 2024. It is now read-only.
[TT-6478] Fix control-plane label so that it does not conflict with other tools #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zalbiraw
changed the title
buraksekili
approved these changes
Mar 9, 2023
|
@zalbiraw can you also update CHANGELOG according to the changes introduced in the PR? Sorry, I totally forgot it while reviewing |
|
Done! |
|
Kudos, SonarCloud Quality Gate passed!
|
buger
pushed a commit
that referenced
this pull request
May 22, 2024
…ther tools (#583) * Fix control-plane label so that it does not conflict with other tools * Update changelog --------- Co-authored-by: Pranshu <104971506+singhpr@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently our labels filter on
control-plane:controller-managerlabels which are generic and can cause clashes with different tools such as gatekeeper. This PR changes thecontroller-managervalue totyk-operator-controller-managerto avoid those issues.Description
Related Issue
Motivation and Context
Test Coverage For This Change
Screenshots (if appropriate)
Types of changes
Checklist
master!masterbranch (left side). Also, it would be best if you started your change off our latestmaster.make manifestsmake helmgofmt -s -w .go vet ./...golangci-lint run