Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

[SYSE-304]: Update release engineering code to be manageable by gromit templates #131

Merged
merged 20 commits into from
Dec 20, 2023
Merged

[SYSE-304]: Update release engineering code to be manageable by gromit templates #131

merged 20 commits into from
Dec 20, 2023

Conversation

asutosh
Copy link

@asutosh asutosh commented Dec 19, 2023 •
edited
Loading

This PR:

  • Updates all the releng code to follow the current structure that is templated using gromit.(with the ci/ directory hierarchy and everything)
  • Removes all the bits that are not relevant to the CLI app(service files, post install, pre install scripts for packages etc.)
  • Fixes all the upgrade tests that were out of date.
  • The version injection wasn't working correctly because the current VERSION string cmd.VERSION was a const so not injectable at build time, changes this to a var.
  • Updates the Dockerfile to use a non-root user as sonarcloud was complaining - should not be an issue running as a non-root/non-system user as it's just a cli app.

@asutosh
Initial moving around.
6d5c272 
Move all relevant files to ci/
Update release.yml with only what's required.
Update goreleaser.yml to suit  a cli app specific release.
@sweep-ai Sweep AI
Copy link

sweep-ai bot commented Dec 19, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@asutosh asutosh mentioned this pull request Dec 19, 2023
Closed
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

alephnull
alephnull approved these changes Dec 20, 2023
View reviewed changes
Copy link

@alephnull alephnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@asutosh asutosh merged commit 149fde3 into master Dec 20, 2023
29 checks passed
@asutosh asutosh deleted the syse-304/releng-changes branch December 20, 2023 13:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alephnull alephnull alephnull approved these changes

@tbuchaillot tbuchaillot Awaiting requested review from tbuchaillot

@ermirizio ermirizio Awaiting requested review from ermirizio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asutosh @alephnull