This repository has been archived by the owner on Oct 11, 2024. It is now read-only.
TT-12269 Remove api_definition field from dump command's output for OAS APIs
#158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IF API Definition represents OAS APIs. The reason of this change is that `api_definition` field in the output of OAS is redundant for OAS APIs which only needs `oas` field. Signed-off-by: Burak Sekili <buraksekili@gmail.com>
Signed-off-by: Burak Sekili <buraksekili@gmail.com>
Signed-off-by: Burak Sekili <buraksekili@gmail.com>
TykSpec Signed-off-by: Burak Sekili <buraksekili@gmail.com>
komalsukhani
suggested changes
Jun 6, 2024
Co-authored-by: Komal Sukhani <komaldsukhani@gmail.com>
Co-authored-by: Komal Sukhani <komaldsukhani@gmail.com>
Signed-off-by: Burak Sekili <buraksekili@gmail.com>
…kTechnologies/tyk-sync into feat/TT-12269/remove-redundant-fields
or OAS) Signed-off-by: Burak Sekili <buraksekili@gmail.com>
Signed-off-by: Burak Sekili <buraksekili@gmail.com>
Signed-off-by: Burak Sekili <buraksekili@gmail.com>
Signed-off-by: Burak Sekili <buraksekili@gmail.com>
…ition Signed-off-by: Burak Sekili <buraksekili@gmail.com>
Signed-off-by: Burak Sekili <buraksekili@gmail.com>
komalsukhani
suggested changes
Jun 11, 2024
Signed-off-by: Burak Sekili <buraksekili@gmail.com>
Signed-off-by: Burak Sekili <buraksekili@gmail.com>
Signed-off-by: Burak Sekili <buraksekili@gmail.com>
komalsukhani
approved these changes
Jun 12, 2024
…y in the definition stored locally Signed-off-by: Burak Sekili <buraksekili@gmail.com>
Signed-off-by: Burak Sekili <buraksekili@gmail.com>
[TT-12400] Fix help messages
Co-authored-by: Burak Sekili <buraksekili@gmail.com>
Signed-off-by: Burak Sekili <buraksekili@gmail.com>
Signed-off-by: Burak Sekili <buraksekili@gmail.com>
Signed-off-by: Burak Sekili <buraksekili@gmail.com>
…s-format [TT-12501] (bug): fix validation of API type
…s_issue [TT-12430] Sync should work with Dashboard using SQL database
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes
api_definitionif the dump command dumps OAS APIs. For OAS APIs, the dump command's output will only containoasfield to make it align with Tyk Dashboard.Related Issue
https://tyktech.atlassian.net/browse/TT-12269
Motivation and Context
Test Coverage For This Change
Screenshots (if appropriate)
Types of changes
Checklist
master!masterbranch (left side). Also, it would be best if you started your change off our latestmaster.gofmt -s -w .go vet ./...golangci-lint run