Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

TT-309 Issue-29 #31

Merged
merged 1 commit into from
Jun 10, 2020
Merged

TT-309 Issue-29 #31

merged 1 commit into from
Jun 10, 2020

Conversation

tbuchaillot
Copy link

@tbuchaillot tbuchaillot commented May 11, 2020

Description

Related #29 .

The idea behind this PR is to get orgID from dashboard automatically if no -o flag is passed to the execution.
It also solves some problems with publish command, since it wasn't enforcing the orgID given.

Testing

Tested using a dump of 1 API and 1 Policy from environment A in environment B ( different orgID's). API with OIDC configured with 2 issuers (related to that policy) and the Policy with that API configured in AccessRights.

  • Use command sync specifying dashboard URL and secret. The API and Policy should be synced and don't throw an error.
  • Use command sync specifying dashboard URL, secret and orgID. The API and Policy should be synced and don't throw an error only if the orgID is valid. If not it should throw an error.
  • Use command publish specifying dashboard URL and secret. The API and Policy should be published and don't throw an error.
  • Use command publish specifying dashboard URL, secret and orgID. The API and Policy should be published and don't throw an error only if the orgID is valid. If not it should throw an error.

@tbuchaillot tbuchaillot self-assigned this May 11, 2020
Copy link

@matiasinsaurralde matiasinsaurralde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 💯

@matiasinsaurralde matiasinsaurralde linked an issue Jun 3, 2020 that may be closed by this pull request
@matiasinsaurralde matiasinsaurralde merged commit ee9ff0e into master Jun 10, 2020
@matiasinsaurralde matiasinsaurralde deleted the auto-orgid branch June 10, 2020 13:28
@gregdelhon gregdelhon changed the title Issue-29 TT-309 Issue-29 Sep 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TT-309 Get orgID automatically in sync
2 participants