Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please include a nested JSON object on the policy #2717

Closed
christtyk opened this issue Dec 6, 2019 · 10 comments · Fixed by #2725
Closed

Please include a nested JSON object on the policy #2717

christtyk opened this issue Dec 6, 2019 · 10 comments · Fixed by #2725

Comments

@christtyk
Copy link
Contributor

christtyk commented Dec 6, 2019

Regarding https://support.tyk.io/a/tickets/3793,

Could we please request an enhancement to include a nested JSON object, similar to this one, on the policy(https://tyk.io/docs/security/security-policies/policies-guide/) ? Can this also be prioritised to be bundled with the 2.8.3 please ?

We just want a nested JSON object, similar to this one, included on the Oauth client & on the policy definition.

"meta_data" :{ "key1": "value1", "key2": "value2", "key3": "value3"}

@jensneuse
Copy link
Contributor

What problem are we solving?

@furkansenharputlu furkansenharputlu self-assigned this Dec 9, 2019
@christtyk
Copy link
Contributor Author

@jensneuse have given @furkansenharputlu details of the support ticket, if you'd like it let me know

buger pushed a commit that referenced this issue Dec 12, 2019
tykbot bot pushed a commit that referenced this issue Dec 12, 2019
Fixes #2717 

(cherry picked from commit deb45e4)
@lghiur lghiur self-assigned this Dec 19, 2019
@ilijabojanovic
Copy link
Member

@furkansenharputlu

Seems we have some merge issue on something. Metadata filed are visible on policy page, when we update policy with metadata api returns 200 status code, but data is not saved in database.

Screen Shot 2019-12-30 at 21 32 04

Screen Shot 2019-12-30 at 21 32 11

But data isn't saved in Database

Screen Shot 2019-12-30 at 21 40 49

@furkansenharputlu
Copy link
Contributor

@ilijabojanovic the dashboard change wasn't added to the release branch. I added, It should work now.

@ilijabojanovic
Copy link
Member

@furkansenharputlu on latest release-1.9 branch i still don't see this change
https://github.com/TykTechnologies/tyk-analytics/commits/release-1.9

@maciejwojciechowski
Copy link
Contributor

meta is not visible on UI when opening policy. seems UI issue as data is present in response

image

@christtyk
Copy link
Contributor Author

@furkansenharputlu if there's any risk this won't be included please let me know, is for a large client.

@furkansenharputlu
Copy link
Contributor

@christtyk it will be released. @lghiur, the comment above that @maciejwojciechowski added shows that it seems a FE issue. Can you please have a look ?

@lghiur lghiur closed this as completed Jan 8, 2020
@maciejwojciechowski
Copy link
Contributor

maciejwojciechowski commented Jan 20, 2020

verified over UI and api api/portal/policies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants