Fix return overrides to override error bodies #2815
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous PR #2731 contained an error, and always forced return custom error: which brakes backward compatibility.
In this PR I added tests covering all return overrides functionality and normalized its behavior for JSVM and Python.
Additionally, it use reverse logic now, and plugin needs set
ReturnOverrides.OverrideError
(JS) orreturn_overrides.override_error
(Python) totrue
in order to override the body of response.Additionally, I renamed
response_error
field toresponse_body
, because it makes way more sense.The old field still can be set for backward compatibility.
Example python middleware:
#2693