Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TT-4035] Release 4.0 plugin compiler workaround #3794

Closed
wants to merge 3 commits into from

Conversation

jeffy-mathew
Copy link
Contributor

@jeffy-mathew jeffy-mathew commented Dec 20, 2021

This PR intends to fix - plugin.Open("plugin"): plugin was built with a different version of package for gw dependencies.
This issue won't occur locally if a replace directive is used in go.mod to replace the gw dependency with a local copy.

Since the gw is built in our release pipeline in github actions workspace directory __w/tyk/tyk, we can clone the corresponding gw version into __w/tyk/tyk and use a replace directive for gw while building the plugin and it'll be fixed.

Related issue - golang/go#31354

@jeffy-mathew jeffy-mathew changed the title Release 4.0 plugin compiler fix [TT_4035] Release 4.0 plugin compiler fix Dec 20, 2021
@jeffy-mathew jeffy-mathew changed the title [TT_4035] Release 4.0 plugin compiler fix [TT-4035] Release 4.0 plugin compiler fix Dec 20, 2021
Copy link
Contributor

@alephnull alephnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as long as the tests pass.

@jeffy-mathew jeffy-mathew changed the title [TT-4035] Release 4.0 plugin compiler fix [TT-4035] Release 4.0 plugin compiler workaround Dec 21, 2021
@jeffy-mathew jeffy-mathew marked this pull request as draft December 22, 2021 09:19
@jeffy-mathew jeffy-mathew deleted the release-4.0-plugin-fix branch December 23, 2021 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants