Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Corner Colors - BLANK enum and restore on reset #85

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

sjtrny
Copy link
Contributor

@sjtrny sjtrny commented Jun 15, 2024

Change Summary:

  1. Color definitions have been centralised
  2. Modified the BLANK constant to have a non None value to resolve equality checks
  3. The world corner_colors dictionary is now auto-filled with BLANK when corner color not provided
  4. Painting BLANK corner color is now supported
  5. Initial corner color state is restored when calling reset_world

Added associated tests for new functionality.

This PR resolves the following issues:

  1. BLANK Corner Color #74
  2. Corner Colors Not Restored #75

Copy link

codecov bot commented Jun 15, 2024

Codecov Report

Attention: Patch coverage is 96.29630% with 1 line in your changes missing coverage. Please review.

Project coverage is 42.22%. Comparing base (28e34b2) to head (eb5d1ac).
Report is 14 commits behind head on main.

Current head eb5d1ac differs from pull request most recent head 005e6db

Please upload reports for the commit 005e6db to get more accurate results.

Files Patch % Lines
stanfordkarel/karel_world.py 95.65% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #85      +/-   ##
==========================================
+ Coverage   41.47%   42.22%   +0.75%     
==========================================
  Files          10       10              
  Lines        1372     1376       +4     
==========================================
+ Hits          569      581      +12     
+ Misses        803      795       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant