Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add params and MACs units specifiers #188

Merged

Conversation

richardtml
Copy link
Contributor

I've added fomatting.params_units and fomatting.macs_units units specifiers, see issue #183 .

@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

Merging #188 (6bffb37) into main (fde1cf0) will increase coverage by 0.10%.
The diff coverage is 97.05%.

@@            Coverage Diff             @@
##             main     #188      +/-   ##
==========================================
+ Coverage   97.36%   97.47%   +0.10%     
==========================================
  Files           6        6              
  Lines         570      594      +24     
==========================================
+ Hits          555      579      +24     
  Misses         15       15              
Impacted Files Coverage Δ
torchinfo/model_statistics.py 98.50% <95.45%> (+0.39%) ⬆️
torchinfo/__init__.py 100.00% <100.00%> (ø)
torchinfo/enums.py 100.00% <100.00%> (ø)
torchinfo/formatting.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@TylerYep
Copy link
Owner

TylerYep commented Nov 6, 2022

Awesome work here! I'm going to make a couple tweaks to make the configs into enums, but otherwise this should be ready to merge soon.

@TylerYep TylerYep merged commit 8b3ae72 into TylerYep:main Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants