Add the "groups" column. #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andravin
force-pushed
the
feature-conv-groups
branch
from
42edc3c
to
154d07e
Compare
|
Thanks for submitting this PR! This change is looking good. Could you add a new unit test and get the existing tests passing so I can review this further? |
Add test_groups(). Add groups field to single_input_all_cols.out Add Groups field to parameter_list.out
andravin
force-pushed
the
feature-conv-groups
branch
from
3f49f9a
to
a9b2f08
Compare
This changes the order of the ColumnSettings enumeration.
|
I added a test for the GROUPS column and fixed the existing tests. There are two commits. The first one just adds the GROUPS column to the end of the ColumnSettings enumeration, causing the GROUPS column to be last in the printed output. I thought this looked wrong, so I made a second commit that inserts the GROUPS column after the KERNEL_SIZE column. |
|
Thanks! Great work here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #319.