Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Custom start index for ordered lists (#1299), improved support for copy/pasting tables into speadsheets (#1298) #1311

Closed
wants to merge 7 commits into from

Conversation

areknawo
Copy link
Collaborator

@areknawo areknawo commented Dec 9, 2024

This PR:

Copy link

vercel bot commented Dec 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
blocknote ✅ Ready (Inspect) Visit Preview Dec 11, 2024 3:30pm
blocknote-website ✅ Ready (Inspect) Visit Preview Dec 11, 2024 3:30pm

Copy link

vercel bot commented Dec 9, 2024

@areknawo is attempting to deploy a commit to the TypeCell Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Collaborator

@YousefED YousefED left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like a good start, I see one major bug when creating a list

  1. first item
  2. second item

and then indenting the second item, the index shows as 1.

I also don't think we always want to export the list index to BlockNote JSON format. When I look at basic/block-objects example, now the index is always included. Imo we should only include it if there's an explicit (different from default) "start".

Not sure what the best approach for these two issues is. Perhaps we should keep index as-is, and include a start attribute only when needed?

Copy link
Collaborator

@YousefED YousefED left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of improvement points:

Discussed on slack:

  • add tests
  • make sure start doesn't show up for non-explicitly set list items

other:

  • when starting a new list with 1., we shouldn't set start=1, as it's the default behavior
  • found one bug with inconsistent data / UX, see recording:
Screen.Recording.2024-12-10.at.09.53.03.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants