-
-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Custom start index for ordered lists (#1299), improved support for copy/pasting tables into speadsheets (#1298) #1311
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@areknawo is attempting to deploy a commit to the TypeCell Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like a good start, I see one major bug when creating a list
- first item
- second item
and then indenting the second item, the index shows as 1
.
I also don't think we always want to export the list index to BlockNote JSON format. When I look at basic/block-objects
example, now the index is always included. Imo we should only include it if there's an explicit (different from default) "start".
Not sure what the best approach for these two issues is. Perhaps we should keep index
as-is, and include a start
attribute only when needed?
packages/core/src/api/exporters/html/util/serializeBlocksExternalHTML.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of improvement points:
Discussed on slack:
- add tests
- make sure
start
doesn't show up for non-explicitly set list items
other:
- when starting a new list with 1., we shouldn't set start=1, as it's the default behavior
- found one bug with inconsistent data / UX, see recording:
This PR:
\d+\.
shortcut; (list keyboard shortcut other than "1" #1299)OL
start
attribute in HTML & MD output;