-
-
Couldn't load subscription status.
- Fork 624
fix: Default themes contrast #2129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@blocknote/ariakit
@blocknote/code-block
@blocknote/core
@blocknote/mantine
@blocknote/react
@blocknote/server-util
@blocknote/shadcn
@blocknote/xl-ai
@blocknote/xl-docx-exporter
@blocknote/xl-email-exporter
@blocknote/xl-multi-column
@blocknote/xl-odt-exporter
@blocknote/xl-pdf-exporter
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not entirely certain about this change, the low contrast was fairly intentional to make it not look like the normal text. I am unsure that we actually need to apply the guidelines for what is essentially decorative text.
I'll let @YousefED decide here though
|
There's a difficult trade-off here (improving accessibility vs staying more inline with other visual design decisions). My preference would be to expose this as a separate option / theme. For now - let's hold off on merging this directly |
Summary
Currently, the the value set for the
--bn-colors-side-menuCSS variable in the default light and dark themes, has a contrast that is too low relative to the--bn-colors-editor-backgroundvariable.This is relevant because it's used for the side menu and block placeholder text colors, and doesn't comply with WCAG accessibility standards.
This PR changes the value of
--bn-colors-side-menuto comply with the WCAG 2 AAA standard.Closes #1983
Rationale
Useful improvement for vision impaired users.
Changes
Updated
--bn-colors-side-menuCSS variable value for light and dark default themes.Impact
N/A
Testing
N/A
Screenshots/Video
N/A
Checklist
Additional Notes