Playwright refactor fixes

.github/workflows/build.yml

@@ -74,5 +74,5 @@ jobs:
         if: always()
         with:
           name: playwright-report
-          path: playwright-report/
+          path: tests/playwright-report/
           retention-days: 30

examples/editor/src/style.css

@@ -1,13 +1,14 @@
 .editor {
   margin: 0 calc((100% - 731px) / 2);
-  height: 100%;
+  margin-top: 8px;
+  /* height: 100%; */
 }
 
 body {
   margin: 0;
 }
 
-.root {
+/* .root {
   height: 100%;
   width: 100%;
-}
+} */

packages/core/src/api/exporters/markdown/markdownExporter.test.ts

@@ -1,6 +1,7 @@
+import fs from "node:fs";
+import path from "node:path";
 import { afterEach, beforeEach, describe, expect, it } from "vitest";
 import { BlockNoteEditor } from "../../../BlockNoteEditor";
-
 import {
   BlockSchema,
   PartialBlock,
@@ -34,6 +35,16 @@ async function convertToMarkdownAndCompareSnapshots<
     "/" +
     snapshotName +
     "/markdown.md";
+
+  // vitest empty snapshots are broken on CI. might be fixed on next vitest, use workaround for now
+  if (!md.length && process.env.CI) {
+    if (
+      fs.readFileSync(path.join(__dirname, snapshotPath), "utf8").length === 0
+    ) {
+      // both are empty, so it's fine
+      return;
+    }
+  }
   expect(md).toMatchFileSnapshot(snapshotPath);
 }
 

packages/core/src/extensions/FormattingToolbar/FormattingToolbarPlugin.ts

@@ -1,4 +1,4 @@
-import { isNodeSelection, isTextSelection, posToDOMRect } from "@tiptap/core";
+import { isNodeSelection, posToDOMRect } from "@tiptap/core";
 import { EditorState, Plugin, PluginKey } from "prosemirror-state";
 import { EditorView } from "prosemirror-view";
 
@@ -29,15 +29,7 @@ export class FormattingToolbarView {
     state: EditorState;
     from: number;
     to: number;
-  }) => boolean = ({ state }) => {
-    const { selection } = state;
-    const { empty } = selection;
-
-    if (!isTextSelection(selection)) {
-      return false;
-    }
-    return !empty;
-  };
+  }) => boolean = ({ state }) => !state.selection.empty;
 
   constructor(
     private readonly editor: BlockNoteEditor<

packages/core/src/extensions/SlashMenu/defaultSlashMenuItems.ts

@@ -19,18 +19,15 @@ function setSelectionToNextContentEditableBlock<
   S extends StyleSchema
 >(editor: BlockNoteEditor<BSchema, I, S>) {
   let block = editor.getTextCursorPosition().block;
-  let contentType = editor.blockSchema[block.type].content as
-    | "inline"
-    | "table"
-    | "none";
+  let contentType = editor.blockSchema[block.type].content;
 
   while (contentType === "none") {
-    editor.setTextCursorPosition(block, "end");
     block = editor.getTextCursorPosition().nextBlock!;
     contentType = editor.blockSchema[block.type].content as
       | "inline"
       | "table"
       | "none";
+    editor.setTextCursorPosition(block, "end");
   }
 }
 

tests/src/end-to-end/copypaste/copypaste.test.ts-snapshots/images-json-chromium-linux.json

@@ -38,7 +38,6 @@
               "type": "image",
               "attrs": {
                 "textAlignment": "left",
-                "backgroundColor": "default",
                 "url": "https://www.pulsecarshalton.co.uk/wp-content/uploads/2016/08/jk-placeholder-image.jpg",
                 "caption": "",
                 "width": 462
@@ -96,7 +95,6 @@
               "type": "image",
               "attrs": {
                 "textAlignment": "left",
-                "backgroundColor": "default",
                 "url": "https://www.pulsecarshalton.co.uk/wp-content/uploads/2016/08/jk-placeholder-image.jpg",
                 "caption": "",
                 "width": 462

tests/src/end-to-end/images/images.test.ts

@@ -10,7 +10,7 @@ import { compareDocToSnapshot, focusOnEditor } from "../../utils/editor";
 import { dragAndDropBlock } from "../../utils/mouse";
 import { executeSlashCommand } from "../../utils/slashmenu";
 
-const IMAGE_UPLOAD_PATH = "tests/end-to-end/images/placeholder.png";
+const IMAGE_UPLOAD_PATH = "src/end-to-end/images/placeholder.png";
 const IMAGE_EMBED_URL =
   "https://www.pulsecarshalton.co.uk/wp-content/uploads/2016/08/jk-placeholder-image.jpg";