Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provision of jsonschema for yang.settings from origin #233

Closed
esmasth opened this issue Feb 27, 2024 · 1 comment
Closed

Provision of jsonschema for yang.settings from origin #233

esmasth opened this issue Feb 27, 2024 · 1 comment

Comments

@esmasth
Copy link
Contributor

esmasth commented Feb 27, 2024

I have a working jsonschema based on https://json-schema.org/, which helps a lot in populating the yang.settings file in my projects.

It would be great to get it from the origin so that projects like TypeFox/yang-vscode can apply the validation through the IDEs without user management of YANG LSP used by the IDE/editor and corresponding applicable JSON schema out of band for each project.
@esmasth esmasth mentioned this issue Feb 27, 2024
Closed
esmasth added a commit to esmasth/yang-lsp that referenced this issue Mar 10, 2024
@esmasth
Introduce yang-lsp-settings-schema.json
a7f0638 
The JSON Schema for the yang.settings file is specified to allow for
various IDE plugins to take the LSP version corresponding schema and
associate them to the yang.settings for ease of editing and review.

It is also updated that yang.settings is a JSON with Comments filetype
since it was already supporting comments.

This change addresses the issue TypeFox#233

Signed-off-by: Siddharth Sharma <siddharth.sharma@ericsson.com>
This was referenced Mar 10, 2024
Merged
Merged
esmasth added a commit to esmasth/yang-lsp that referenced this issue Mar 16, 2024
@esmasth
Distribute yang-lsp-settings-schema.json
3e62b40 
Also modularize editorconfig settings

This change relates to TypeFox#233

Signed-off-by: Siddharth Sharma <siddharth.sharma@ericsson.com>
esmasth added a commit to esmasth/yang-lsp that referenced this issue Mar 16, 2024
@esmasth
Distribute yang-lsp-settings-schema.json
60b30d2 
Also modularize editorconfig settings

This change relates to TypeFox#233

Signed-off-by: Siddharth Sharma <siddharth.sharma@ericsson.com>
esmasth added a commit to esmasth/yang-lsp that referenced this issue Mar 16, 2024
@esmasth
Added defaultSnippets to json schema
e66c18e 
Also
- added markdownDescription statements to json schema
- modularized editorconfig settings, and added more files
- resolved markdownlint warnings

This change relates to TypeFox#233

Signed-off-by: Siddharth Sharma <siddharth.sharma@ericsson.com>
@esmasth esmasth mentioned this issue Mar 16, 2024
Merged
esmasth added a commit to esmasth/yang-lsp that referenced this issue Mar 16, 2024
@esmasth
Added defaultSnippets to json schema
3e7d43e 
Also
- added markdownDescription statements to json schema
- modularized editorconfig settings, and added more files
- resolved markdownlint warnings

This change relates to TypeFox#233

Signed-off-by: Siddharth Sharma <siddharth.sharma@ericsson.com>
esmasth added a commit to esmasth/yang-lsp that referenced this issue Mar 16, 2024
@esmasth
Added defaultSnippets to json schema
eed7fc7 
Also
- added markdownDescription statements to json schema
- modularized editorconfig settings, and added more files
- resolved markdownlint warnings

This change relates to TypeFox#233

Signed-off-by: Siddharth Sharma <siddharth.sharma@ericsson.com>
esmasth added a commit to esmasth/yang-lsp that referenced this issue Mar 16, 2024
@esmasth
Add defaultSnippets to json schema
2d4bf01 
Also
- added markdownDescription statements to json schema
- modularized editorconfig settings, and added more files
- resolved markdownlint warnings

This change relates to TypeFox#233

Signed-off-by: Siddharth Sharma <siddharth.sharma@ericsson.com>
esmasth added a commit to esmasth/yang-lsp that referenced this issue Mar 22, 2024
@esmasth
Distribute yang-lsp-settings-schema.json
ff781be 
Also modularize editorconfig settings

This change relates to TypeFox#233

Signed-off-by: Siddharth Sharma <siddharth.sharma@ericsson.com>
esmasth added a commit to esmasth/yang-lsp that referenced this issue Mar 22, 2024
@esmasth
Add defaultSnippets to json schema
7814a29 
Also
- added markdownDescription statements to json schema
- modularized editorconfig settings, and added more files
- resolved markdownlint warnings

This change relates to TypeFox#233

Signed-off-by: Siddharth Sharma <siddharth.sharma@ericsson.com>
@esmasth
Copy link
Contributor Author

esmasth commented Apr 12, 2024

#238 which addresses this is merged

@esmasth esmasth closed this as completed Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@esmasth