You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason will be displayed to describe this comment to others. Learn more.
In your example tsconfig, you use !node_modules/**/*.d.ts in the filesGlob section. On Windows, this didn't work for me, and I had to use !./node_modules/**/*.d.ts including the leading ./. You might consider updating the example.
The reason will be displayed to describe this comment to others. Learn more.
Your welcome! I've recently switched from VS to Atom, because the programming experience is better, which is a credit to your good work!
BTW may I suggest a few things:
- when deleting a file in atom, the tsconfig I'd not adjusted, which led to compile errors in my case (I had a *.ts file that I didn't use in the VS project, but was automatically included, and which have compiler errors. But even after deleting this file, the compiler generated the same warnings until I manually deleted the file from tsconfig.
- Ctrl-B jumps to the import statement, whereas I would normally prefer to jump to the actual class. Alternatively, in case you prefer to keep things like that, could you move the cursor position to the imported name instead of the first column, so that pursuing CTRL -B twice will jump to the class.
New feature requests:
- I'm currently working with two projects at the same time: One for developing directives, the other for the front-end. Is it possible to have both projects open in one atom editor, as I currently have two versions open, each with their own tsconfig? A kind of VS solution file that refers to two project files.
- in VS and sublime, when I press CTRL-tab, it moves the cursor to the last visited file instead of the next tab. This allows me to switch quickly between my most recent files.
Thanks again for listening,
Cheers,
Erik
-----Original Message-----
From: "Basarat Ali Syed" notifications@github.com
Sent: 22/03/2015 04:35
To: "TypeStrong/atom-typescript" atom-typescript@noreply.github.com
Cc: "Erik Vullings" erik.vullings@gmail.com
Subject: Re: [atom-typescript] 📝 clarify `formatCodeOptions` (1380a83)
@erikvullings thanks we discovered that and updated the default glob we generate already : https://github.com/TypeStrong/atom-typescript/blob/master/lib/main/tsconfig/tsconfig.ts#L137 Thanks for pointing us to fix the docs (done : b92d2db) Have a lovely weekend.
—
Reply to this email directly or view it on GitHub.
The reason will be displayed to describe this comment to others. Learn more.
in VS and sublime, when I press CTRL-tab, it moves the cursor to the last visited file instead of the next tab. This allows me to switch quickly between my most recent files.
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the response! BTW you can see the total set of Atom tools that I
use here https://github.com/TNOCS/csWeb/wiki/IDE-and-other-tooling.
I actually use another tab switchter, Enhanced tabs
https://atom.io/packages/enhanced-tabs, which works quite nice.
Unfortunately, CTRL-B (lookup definition) bypasses its buffer when
switching, so after using CTRL-B, I cannot use it to go back. Is there an
option to quickly jump back to where I came from?
Also, I've noticed that there is no Intellisense support for internal
variables in a forEach, e.g. in below example, although r1 and r2's type
are well-defined (and shown in the tooltip), there is no Intellisense
support for r1.
private mergeResults(result1: ILookupResult[], result2: ILookupResult[]) :
ILookupResult[] {
var r: ILookupResult[] = [];
result1.forEach((r1) => {
result2.forEach((r2) => {
r1.
});
});
r = r.sort((a,b) => { return b.score - a.score; });
return r;
}
Finally, I've noticed two issues with the compile behavior that I cannot
explain:
1. When I press CTRL-B, my project compiles to (commonjs) one output
file: when using VS, my gulp task copies the result.js once to a new
destination. In the case of Atom, it seems to create the result.js several
times (at least, my gulp task that monitors the file is called many times).
Do you have a clue why this happens?
2. When I press CTRL-S in a TypeScript project, the project compiles to
one output file, but the generated code has an issue with a class that
extends another. I always have to use CTRL-B to compile the whole project.
Any idea why? I normally only get this issue when the order of classes is
wrong, e.g. class foo extends bar, but foo hasn't been defined yet as the
order of the files is incorrect (bar.ts is before foo.ts in the files
section of the TsConfig).
Cheers,
Erik
On 22 March 2015 at 23:28, Basarat Ali Syed ***@***.*** wrote:
in VS and sublime, when I press CTRL-tab, it moves the cursor to the last
visited file instead of the next tab. This allows me to switch quickly
between my most recent files.
There is a package for that : https://atom.io/packages/tab-switcher I
need to test it though
—
Reply to this email directly or view it on GitHub
1380a83#commitcomment-10335503
.
The reason will be displayed to describe this comment to others. Learn more.
In the case of Atom, it seems to create the result.js several
times (at least, my gulp task that monitors the file is called many times).
Do you have a clue why this happens?
When I press CTRL-S in a TypeScript project, the project compiles to
one output file, but the generated code has an issue with a class that
extends another.
Are you using --out. Can we get a reproducible sample? I personally do not use --out anymore as it doesn't scale.
The reason will be displayed to describe this comment to others. Learn more.
Also, I've noticed that there is no Intellisense support for internal
variables in a forEach, e.g. in below example, although r1 and r2's type
are well-defined (and shown in the tooltip), there is no Intellisense
support for r1.
The reason will be displayed to describe this comment to others. Learn more.
Sorry, my bad. My atom installation got corrupt. Although most plugins still worked, I also wasn't able to upgrade to a new version, and I had to manually remove all references to atom in AppData. I've also discovered literally thousands of temporary linter files with the extension ts in my AppData/temp folder, and deleted them as well. After reinstalling Atom, and atom-typescript (linter and autocomplete-plus), I got it working again.
Side note: After installing a subset of my previously installed packages, your plugin stopped working again. I'll try to discover what happens there and let you know.
Cheers, Erik
-----Original Message-----
From: "Basarat Ali Syed" notifications@github.com
Sent: 24/03/2015 08:20
To: "TypeStrong/atom-typescript" atom-typescript@noreply.github.com
Cc: "Erik Vullings" erik.vullings@gmail.com
Subject: Re: [atom-typescript] 📝 clarify `formatCodeOptions` (1380a83)
Also, I've noticed that there is no Intellisense support for internal
variables in a forEach, e.g. in below example, although r1 and r2's type
are well-defined (and shown in the tooltip), there is no Intellisense
support for r1.
I tried it. It works:
my source:
interface ILookupResult {
name: string;
score: number;
}
function mergeResults(result1: ILookupResult[], result2: ILookupResult[]):
ILookupResult[] {
var r: ILookupResult[] = [];
result1.forEach((r1) => {
result2.forEach((r2) => {
r1.
});
});
r = r.sort((a, b) => { return b.score - a.score; });
return r;
}—
Reply to this email directly or view it on GitHub.
The reason will be displayed to describe this comment to others. Learn more.
Hi again,
I've promised you an example of my project that uses the -out feature and
which has several issues:
- _it cannot use incremental builds_ (actually, it builds something, but
when I use the resulting js file, it complains that __extends is not
defined). I have to do a full build.
- *since version 1.8.0 of atom-typescript my project doesn't compile at
all: *although the building message is generated, an error is generated
in the console (promise is rejected) and no output is generated. I've
copied the stack trace below. Please unzip the attached file and see for
yourself.
The attached project should generate a csComp.js file in the dist folder.
This is loaded in the csMap https://github.com/TNOCS/csMapclient
application to create an Angular SPA map. If you need the front end too,
let me know, and I'll send you a copy too.
Hope this helps.
Cheers,
Erik
"TypeError: Cannot read property 'file' of undefined↵
at
C:\Users\vullingshjlm.atom\packages\atom-typescript\dist\main\lang\modules\building.js:31:24↵
at Array.forEach (native)↵
at Object.emitFile
(C:\Users\vullingshjlm.atom\packages\atom-typescript\dist\main\lang\modules\building.js:30:20)↵
at
C:\Users\vullingshjlm.atom\packages\atom-typescript\dist\main\lang\projectService.js:233:31↵
at Array.map (native)↵
at Object.build
(C:\Users\vullingshjlm.atom\packages\atom-typescript\dist\main\lang\projectService.js:232:50)↵
at Child.RequesterResponder.processRequest
(C:\Users\vullingshjlm.atom\packages\atom-typescript\dist\worker\lib\workerLib.js:38:60)↵
at process.<anonymous>
(C:\Users\vullingshjlm.atom\packages\atom-typescript\dist\worker\lib\workerLib.js:214:23)↵
at process.emit (events.js:119:17)↵
at handleMessage (child_process.js:326:10)"**proto**:
Object__defineGetter__: function **defineGetter**() { [native code]
}**defineSetter**: function **defineSetter**() { [native code]
}**lookupGetter**: function **lookupGetter**() { [native code]
}**lookupSetter**: function **lookupSetter**() { [native code]
}constructor: function Object() { [native code] }hasOwnProperty: function
hasOwnProperty() { [native code] }isPrototypeOf: function isPrototypeOf() {
[native code] }propertyIsEnumerable: function propertyIsEnumerable() {
[native code] }toLocaleString: function toLocaleString() { [native code]
}toString: function toString() { [native code] }valueOf: function valueOf()
{ [native code] }get **proto**: function **proto**() { [native code] }set
**proto**: function **proto**() { [native code] }
.
1380a83There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In your example tsconfig, you use
!node_modules/**/*.d.tsin the filesGlob section. On Windows, this didn't work for me, and I had to use!./node_modules/**/*.d.tsincluding the leading./. You might consider updating the example.1380a83There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@erikvullings thanks ❤️ we discovered that and updated the default glob we generate already : https://github.com/TypeStrong/atom-typescript/blob/master/lib/main/tsconfig/tsconfig.ts#L137 Thanks for pointing us to fix the docs (done : b92d2db) 🌹 Have a lovely weekend.
1380a83There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1380a83There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a package for that : https://atom.io/packages/tab-switcher I need to test it though
1380a83There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it should just work. You can have as many projects as you want open. The active context is determined by the editor your cursor is in ❤️
1380a83There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1380a83There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I use
alt+-from : https://atom.io/packages/last-cursor-position1380a83There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps its triggering
changeduring buffering. Or its annoyed by us building the directory. The code is fairly clear without chance of loops : https://github.com/TypeStrong/atom-typescript/blob/master/lib/main/lang/modules/building.ts#L40-L43 You can put aconsole.errorin there to see its called only once ❤️Are you using
--out. Can we get a reproducible sample? I personally do not use--outanymore as it doesn't scale.1380a83There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With
--outwe would need to support_reference.ts.1380a83There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried it. It works:
my source:
1380a83There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1380a83There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1380a83There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@erikvullings lets move the out discussion here : #206