-
Notifications
You must be signed in to change notification settings - Fork 202
Using "exclude" instead of "filesGlob" in tsconfig.json produces large amounts of pending requests. #634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
So try again, and comment if it still doesn't work 🌹 |
Note - I wound up with a perf problem in grunt-ts when I implemented Here was my fix: Basically I add |
@ralfbiedert Can you confirm whether this is still an issue on the latest release? It's since moved to a more effective glob. |
Did a very quick check with 7.4.1 and it seems to be fixed. The number of pending requests briefly spikes up to 20, but returns to 0 after about 1s. Thanks! |
@ralfbiedert Is the |
Actually, I have the same issue on my project too - I just tried going back multiple versions when it was previously working and it seems I have the same issue still, not sure where or how this got introduced now. |
@basarat Do you have an idea of how to debug the slowness? I can't seem to narrow it down by just throwing out guesses and globbing should not be this slow (ignore is definitely still working outside of Atom). Is there a way to |
Yup Note: There are only two processes ... one managed by atom aka. the atom window that just calls our functions ... and one we run in the background so as to not block the window thread. |
Awesome, thanks 👍 By "whatever process" I was referring to however it was managed, not the number of them, but yeah - where does the different process get started from? 😄 |
Here in parent.ts Its a bit of a mess ... but there wasn't a good OSS typed solution for this problem at that time. I cleaned up with a concept of FWIW TSB has a concept of active project (and tsb.json to list projects) that doesn't hit the disk as much and keeps it all in sync 🌹 |
@blakeembrey: Ahhh, yes, mixed it up. Now that I changed it to |
When I move from
filesGlob
toexcludes
in mytsconfig.json
I get lots of pending requests that take long to resolve, even for tiny stub projects containing only 2 files. For larger projects Atom becomes unusable.Once I revert to
filesGlob
and restart Atom things are back to normal.This bug could be related to #624.
I am using Atom 1.0.19, atom-typescript 7.0.2, Typescript 1.7.0-dev.20151001 on Mac OS 10.11, however I could observe this behavior for older Atom versions, atom-typescript 5.x and Typescript 1.5.
The text was updated successfully, but these errors were encountered: