Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filesGlob not working in 7.11.0 #732

Closed
patsissons opened this issue Nov 18, 2015 · 5 comments
Closed

filesGlob not working in 7.11.0 #732

patsissons opened this issue Nov 18, 2015 · 5 comments

Comments

@patsissons
Copy link

I thought it might just be my complex project that I was working in, but I created an ultra basic project and auto-created a tsconfig.json file to reproduce. no files section is created unfortunately.

My sample environment:

  • /src/test.ts is the only file (just contains 'use strict';)
  • use the Typescript: Create Tsconfig.json Project File command
    • /src/tsconfig.json created

filesGlob section looks like this:

{
    "filesGlob": [
        "**/*.ts",
        "**/*.tsx",
        "!node_modules/**"
    ]
}

tried saving the test.ts, running sync on test.ts, saving tsconfig.json, running sync on tsconfig.json. The typescript panel shows that test.ts belongs to ~src\tsconfig.json and no issues are reported with either file.

This is happening on Win10 with latest atom (1.2.1)

any ideas on what might be wrong? I don't see anything in the dev console...

@unional
Copy link
Contributor

unional commented Nov 18, 2015

Same here.

@patsissons
Copy link
Author

I figured it out. It has to do with the new rewriteTsconfig option (see the docs for more info).

The docs suggest that it defaults to true, but it seems to be false by default right now.

@basarat basarat added the bug label Nov 18, 2015
@basarat
Copy link
Member

basarat commented Nov 18, 2015

@patsissons
Copy link
Author

great turn-around!

@basarat
Copy link
Member

basarat commented Nov 18, 2015

#715

Although I am still thankful to the original author for getting it done (which I was failing to do) 🌹

@TypeStrong TypeStrong locked and limited conversation to collaborators Jan 20, 2019
angelestelar5z added a commit to angelestelar5z/atom-typescript that referenced this issue Aug 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants