Auto format on save

[lordmat0]

#810

I wasn't sure if this should be a default on, so I decided to have it defaulted to off.

[basarat]

so I decided to have it defaulted to off.

Definitely. Don't want user to open someone else's project's typescript file for quick editing just to have it change on them 🌹

[basarat]

Please answer: Can you try on a project that doesn't have the atom key already. Does it work (the tsconfig.json shouldn't be modifed and format on save shouldn't happen and there should be no errors in the atom debug console)? 🌹

[lordmat0]

I tried it already, it works correctly :), been testing on atom-typescript-examples

We create the key here:
https://github.com/lordmat0/atom-typescript/blob/auto_format_on_save/lib/main/tsconfig/tsconfig.ts#L402-L406

Before I use it here:
https://github.com/lordmat0/atom-typescript/blob/auto_format_on_save/lib/main/tsconfig/tsconfig.ts#L445

Would it also not be worth adding it as a menu item? so others using atom on the same project don't have to share the same setting.

[basarat]

Would it also not be worth adding it as a menu item? so others using atom on the same project don't have to share the same setting.

You mean atom config item? No. Its good to have this shared as a requirement on using the project 🌹

[basarat]

Released : https://github.com/TypeStrong/atom-typescript/releases/tag/v8.1.0 🌹

[s00500]

Has this feature been removed again? Why?