Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 818/angular component html highlighing #948

Conversation

GregOnNet
Copy link
Contributor

@GregOnNet GregOnNet commented May 13, 2016

EDIT Please refer to #949 first because it will fix the build-error occurring here.

Hi,

I added a custom grammar to scripts/grammar.js enabling html syntax highlighting inside Angular's @Component decorator.

The result looks like this.

book-details_component_ts_ __users_gregor_development_projects_angular_book_book-monkey2

Please let me know if this is valuable for you or if I you need further information.

Kind Regards
Greg

Gregor Woiwode added 2 commits May 13, 2016 09:21
@fmalcher
Copy link

👍

@ghost
Copy link

ghost commented May 13, 2016

good work and very useful 👍

@GregOnNet GregOnNet mentioned this pull request May 13, 2016
@JohannesHoppe
Copy link

i definitely would like use this feature 👍

@MarkPieszak
Copy link

Huge win for Atom & Typescript here 👍

@blakeembrey
Copy link
Member

LGTM 👍 How does this work with an escaped back tick? Is it handling it?

@GregOnNet
Copy link
Contributor Author

Do you mean something like <span>```content</span>?

I will test it when I am back at home today.

@blakeembrey
Copy link
Member

blakeembrey commented May 13, 2016

Yeah, just one in the middle.

`<span>\`content</span>`

Edit: Thanks. I haven't been involved with Atom lately and have been busy so can't contribute much to atom-typescript myself.

@GregOnNet
Copy link
Contributor Author

@blakeembrey Good point. It was not managing escaped back ticks.
I updated the regex by adding a negative look behind to the RegEx: https://regex101.com/r/hV8rS2/1

I have to thank the whole atom-typescript-Team for the great work you have done! 👍

Now it shall work.

book-details_component_ts_ __users_gregor_development_projects_angular_book-monkey2

//cc @basarat

@blakeembrey
Copy link
Member

Seems good to me, I'd like to leave @basarat to handle now 😄

@basarat basarat merged commit cbc2382 into TypeStrong:master May 14, 2016
@basarat
Copy link
Member

basarat commented May 14, 2016

Thanks everyone 🌹 https://github.com/TypeStrong/atom-typescript/releases/tag/v8.10.0

@albtdd
Copy link

albtdd commented May 20, 2016

Great, It works for me!
Thank you!

@GregOnNet
Copy link
Contributor Author

You are welcome, sir. 😃

@TypeStrong TypeStrong locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants