-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 818/angular component html highlighing #948
Issue 818/angular component html highlighing #948
Conversation
Applies for @component decorator provided by Angular 2 TypeStrong#818
This is done by running `npm run build` TypeStrong#818
👍 |
good work and very useful 👍 |
i definitely would like use this feature 👍 |
Huge win for Atom & Typescript here 👍 |
LGTM 👍 How does this work with an escaped back tick? Is it handling it? |
Do you mean something like I will test it when I am back at home today. |
Yeah, just one in the middle. `<span>\`content</span>` Edit: Thanks. I haven't been involved with Atom lately and have been busy so can't contribute much to |
Done by running npm run build
@blakeembrey Good point. It was not managing escaped back ticks. I have to thank the whole Now it shall work. //cc @basarat |
Seems good to me, I'd like to leave @basarat to handle now 😄 |
Great, It works for me! |
You are welcome, sir. 😃 |
EDIT Please refer to #949 first because it will fix the build-error occurring here.
Hi,
I added a custom grammar to
scripts/grammar.js
enabling html syntax highlighting inside Angular's@Component
decorator.The result looks like this.
Please let me know if this is valuable for you or if I you need further information.
Kind Regards
Greg