Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement go to declaration with hyperclick provider #995

Merged
merged 2 commits into from
Jul 11, 2016

Conversation

wingyplus
Copy link
Contributor

@wingyplus wingyplus commented Jul 6, 2016

Hi

I see #448 talk about this.​ Any suggestions are welcome.

@basarat basarat merged commit 2b60fe2 into TypeStrong:master Jul 11, 2016
@basarat
Copy link
Member

basarat commented Jul 11, 2016

@wingyplus
Copy link
Contributor Author

@basarat It doesn't work. Is it compile manually?

@basarat
Copy link
Member

basarat commented Jul 11, 2016

Is it compile manually?

sadly. As atom packages are essentially just git tags so whatever is in git is what makes it to the user system (other than npm install) 🌹

@tlaverdure
Copy link

Should this only work for typescript files? It seems to be activation on all file types like css, less, scss, html...

@athyuttamre
Copy link

This is a big step up! Thanks for implementing!

@wingyplus
Copy link
Contributor Author

@tlaverdure hyperclick enabled all filetypes. but in feature "go to declaration" work only typescript filetypes (.ts and .tsx).

@tlaverdure
Copy link

Maybe using the alt key would be better so it doesn't conflict with default atom functionality.

@TypeStrong TypeStrong locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants