Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MaxListenersExceededWarning #723

Closed
tjx666 opened this issue Mar 12, 2022 · 2 comments · Fixed by #733
Closed

MaxListenersExceededWarning #723

tjx666 opened this issue Mar 12, 2022 · 2 comments · Fixed by #733
Labels
bug released

Comments

@tjx666
Copy link

tjx666 commented Mar 12, 2022 •
edited
Loading

Current behavior

After multple time rebuild, throw this warning:

image

After I remove this extension, no this issue.

I can confirm version 6.3.3 no this issue.

Expected behavior

No this warning.

Steps to reproduce the issue

  1. clone repository: git@github.com:tjx666/awesome-chrome-extension-boilerplate.git
  2. checkout to fork-ts-checker-webpack-plugin-issue branch
  3. install dependencies by pnpm install
  4. pnpm start
  5. open src/background/index.ts, modify this file multiple times to triiger rebuild, about 6 times
  6. you will see this warning

Issue reproduction repository

Environment

  • fork-ts-checker-webpack-plugin: 7.2.1
  • typescript: 4.6.2
  • eslint: 8.11.0
  • webpack: 5.70.0
  • os: MacOS 12.2.1
@tjx666 tjx666 added the bug label Mar 12, 2022
@galaxy-s10
Copy link

galaxy-s10 commented Mar 27, 2022 •
edited
Loading

image

I have the same problem，version is ^7.2.1

piotr-oles added a commit that referenced this issue Apr 13, 2022
@piotr-oles
fix: event handler leak in wrapRpc function
414fa2e 
Closes: #723
@piotr-oles piotr-oles mentioned this issue Apr 13, 2022
Merged
piotr-oles added a commit that referenced this issue Apr 13, 2022
@piotr-oles
fix: event handler leak in the wrapRpc function (#733)
be2add9 
We were adding the close event listener but removing the exit one. This commit fixes this leak + few others bugs in this file and adds unit tests to prevent regressions.

Closes: #723
@piotr-oles
Copy link
Collaborator

🎉 This issue has been resolved in version 7.2.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@cssecautomation cssecautomation mentioned this issue Oct 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug released
Projects
None yet
Milestone
No milestone
3 participants
@piotr-oles @tjx666 @galaxy-s10