Work in progress: add eslint typescript support #304
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I forgot to catch up my branch with master right from the off - I think I'll close this and start clean later. |
|
You can rebase and force push in order to reuse this PR, there would be no need to close this (just saying). |
|
Oh sure it's possible - but starting afresh is just easier. Merging upstream wasn't the straightforward affair I'd hoped (much change since I originally forked) |
|
In that case you could also just reset your branch to master, and force push and continue committing from there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLOSED IN FAVOUR OF #305
This PR is intended to start the journey towards adding eslint TypeScript support:
I'm not sure how long it will take to do this as I'm somewhat time poor right now, so all help is appreciated ❤️ 😄
So, what's happened so far? This:
tslint --fixduring commits/test/integration/calledproject_eslint. This contains some simple eslint errors which are visible in VS Code with the ESLint VS Code plugin. In future thefork-ts-checker-webpack-pluginshould pick these up when a test exists to exercise thisTo be continued....!