Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deploying #64

Merged
merged 2 commits into from
Nov 7, 2017
Merged

Fix deploying #64

merged 2 commits into from
Nov 7, 2017

Conversation

piotr-oles
Copy link
Collaborator

No description provided.

@piotr-oles piotr-oles merged commit 288554d into master Nov 7, 2017
@piotr-oles piotr-oles deleted the v0.2.9 branch November 7, 2017 09:42
@johnnyreilly
Copy link
Member

I was just wondering why TypeScript needs to be a dependency? Isn't it only needed at build time? So doesn't it being a devDependency work just fine?

Could be completely wrong - just wanted to understand 😄

@piotr-oles
Copy link
Collaborator Author

Yes, you have right, it should not be in dependencies part :) I've just tried to find out how to fix deploy issue. I've fixed first issue - added skip_cleanup: true directive in .travis.yaml but there is second issue - probably npm key format has been changed or someone regenerated key in our organization. I will check this as soon as possible but I'm affraid it will not be tomorrow :/

@johnnyreilly
Copy link
Member

Sure - this is probably why I've kept the ts-loader release steps rather manual 😉

@johnnyreilly
Copy link
Member

Hey @piotr-oles - any ideas when this will ship? Sorry to chase - we'd just ❤️ to be able to use v0.2.9 🌻

@johnnyreilly
Copy link
Member

Hey @piotr-oles, I hope you're well.

It'd be really nice to be able to use this. Is there anything I can do to help make a release happen? I appreciate this is done in your spare time and so if I can help make this easier then I'd like to offer my services.

@johnnyreilly
Copy link
Member

Hey @piotr-oles, because I'm impatient for the 0.2.9 release I've set up a short-term repo here: https://github.com/typestrong/fork-ts-checker-webpack-plugin

nb The repo above will be removed from GitHub once 0.2.9 is released to npm. This is just for those impatient people out there (well, me mostly 😉) FWIW I noticed that fork-ts-checker-webpack-plugin won't compile with TypeScript 2.6. I fixed that here: 448ba32

I'll submit a PR to the initial repo for you

@johnnyreilly
Copy link
Member

Done - see here: #69

@piotr-oles
Copy link
Collaborator Author

Thank you, PR merged :)

@piotr-oles
Copy link
Collaborator Author

@smonteil - Could you send me the actual npm key by email? There are lot of impatient people waiting for v0.2.9 :)

@johnnyreilly
Copy link
Member

Just to second what @piotr-oles says @smonteil: I'd love to use 0.2.9 from npm rather than my own fork. Please could you provide the key? Thanks!

@piotr-oles
Copy link
Collaborator Author

@vnguyenhuu @etienne-dldc ? :)

@etienne-dldc
Copy link

Hi guys,

sorry for blocking the release 😞,
the key should have been send to you @piotr-oles, please take a look and tell me if it's ok.

@johnnyreilly
Copy link
Member

Thanks!

@piotr-oles
Copy link
Collaborator Author

@etienne-dldc please send it to my work email: piotr.oles@codibly.com - I don't have access to Realytics mail :)

@piotr-oles
Copy link
Collaborator Author

@etienne-dldc ok, I missed it - you send it already there , thanks, I will check it asap :)

@piotr-oles
Copy link
Collaborator Author

@etienne-dldc Thank you, @johnnyreilly fork-ts-checker-webpack-plugin is now available in version 0.2.9 on npm :)

@johnnyreilly
Copy link
Member

Wonderful! Well done all!!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants