refactor: add eslint rules to enforce import order #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SolutionBuilder API is buggy for TypeScript < 3.8.0. To reduce
maintenance burden, we bump minimal TypeScript version for { build: true
} mode to 3.8.0.
BREAKING CHANGE: 🧨 Minimal version of TypeScript with { build: true } mode changed from
3.6.0 to 3.8.0
We want to check for cycle-dependencies to prevent bugs that are not detected by TypeScript type checks. We want also to tag type-only profiles with "import type" annotation to gain visibility.
piotr-oles
force-pushed
the
feature/add-import-rules-to-eslint
branch
from
2483c23 to
51ab607
Compare
piotr-oles
changed the base branch from
alpha
to
fix/bump-minimal-version-of-typescript-for-build-mode
Base automatically changed from
fix/bump-minimal-version-of-typescript-for-build-mode
to
alpha
October 24, 2021 17:22
|
🎉 This PR is included in version 7.0.0-alpha.10 🎉 The release is available on: Your semantic-release bot 📦🚀 |
piotr-oles
added a commit
that referenced
this pull request
Jan 29, 2022
* feat: use simple program for single compilation (no watch) (#574) Use simple ts.Program and ts.CompilerHost when running webpack in non-watch mode. This can improve check time in CI for some cases. BREAKING CHANGE: 🧨 Use ts.Program and ts.CompilerHost for single compilation by default ✅ Closes: #572 * feat: remove eslint support (#607) BREAKING CHANGE: 🧨 ESLint no longer supported by the plugin * chore: merge main changes (#619) * test: use karton for e2e tests (#627) Use external package to handle e2e tests to simplify code base * feat: drop support for webpack 4 (#638) BREAKING CHANGE: 🧨 Webpack 4 is no longer supported. Please upgrade to Webpack ^5.11.0 or use an older version of the plugin. * feat: improve error formatting to match webpack 4 convention (#641) * feat: upgrade dependencies Upgrade dependencies that doesn't require Node version bump. * chore: remove unused dependencies * feat: drop support for node 10 Node 10 is no longer maintained BREAKING CHANGE: 🧨 Require Node.js >= 12 * chore: upgrade dev dependencies * feat: remove support for TypeScript < 3.6.0 (#643) BREAKING CHANGE: 🧨 Drop support for TypeScript < 3.6.0 * feat: port changes from main branch (#649) This commit contains fixes from the main branch * fix: require typescript@^3.8.0 for build: true mode (#672) SolutionBuilder API is buggy for TypeScript < 3.8.0. To reduce maintenance burden, we bump minimal TypeScript version for { build: true } mode to 3.8.0. BREAKING CHANGE: 🧨 Minimal version of TypeScript with { build: true } mode changed from 3.6.0 to 3.8.0 * refactor: add eslint rules to enforce import order (#671) * feat: migrate from reporters to workers (#691) Use simple functions and modules to simplify worker code * refactor: rename files to match convention (#693) I found snake-case easier to read, and given that the project doesn't use OOP a lot, having all PascalCase names doesn't reflect the paradigm and feels unnatural. * feat: simplify logger options (#695) Currently, the logger options are overcomplicated. To simplify them, we are removing logger.infrastructure option. BREAKING CHANGE: 🧨 Changes in options: `logger.issues` becomes `logger`, `logger.devServer` becomes `devServer`, `logger.infrastructure` has been removed * docs: add plugin logo (#696) * refactor: upgrade project dependencies (#698)
|
🎉 This PR is included in version 7.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's part 1 of the bigger effort from #670. This PR doesn't change any logic - only re-formats imports and removes 1 dependency cycle by adding
pluginPools.tsfile