Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement vsproj support #215

Merged
merged 21 commits into from
Mar 27, 2015
Merged

Implement vsproj support #215

merged 21 commits into from
Mar 27, 2015

Conversation

nycdotnet
Copy link
Contributor

This pull request adds support for Visual Studio project files in grunt-ts.

WORK IN PROGRESS - DO NOT MERGE

Examples:

vsproj_test: {
    vs: 'test/vsproj/testproject.csproj'
},
vsproj_test_config: {
    vs: {
        project: 'test/vsproj/testproject.csproj',
        config: 'Release'
    }
},

Known Issues:

  • I upgraded tasks-internal with this latest version - upgrade again before going final since this one still has bugs.
  • Implement vsproj_ignoreFiles_test (done 0734468)
  • Implement vsproj_ignoreSettings_test (done 0734468)
  • Ensure proper errors when using vs with files (will not be supported) (warning implemented in eaec13a).
  • tslint is broken (doesn't handle TypeScript 1.4 union types). (Fixed in d877eb0 by upgrading package.)
  • Blocked by bug in tslint-path-formatter. (removed this dependency in 78ca831)
  • remove temporary nycdotnet grunt task (done c13488b)
  • fix explosion of .baseDir.ts files (Looks like this is solely due to the tests failing and clean:testPost not running (it was)).
  • fix transform regression: test\transform\ts\rootLevel.ts test (getting a line "/// Unknown transform ///ts:(.*):generated" added.) Fixed in 2a2cd0b and 49aa9a1)
  • update documentation including screenshots of Task Runner Explorer in VS 2013 (the docs are updated, but TRX is still too unreliable to recommend).
  • make sure there are no inappropriate warnings when using vs (such as comments/remove comments) (fixed in 8adcbba).
  • make sure UNC paths aren't broken (ts.ts line 204). (actually going to just decide this isn't supported. I don't believe that they worked before either)
  • fix typo in suppressImplicitAnyIndexErrors warning (not plural) (fixed in 6782332)

@nycdotnet
Copy link
Contributor Author

This is a pretty significant change and I may need a bit of help. If anyone can offer some assistance regarding git-fu (reducing the non-changes changes - if possible or ideas for how to crunch them into a single commit), and also help identifying/fixing the cause of the transforms regression (I put a screenshot of the comparison of the expected and actual file.

@nycdotnet
Copy link
Contributor Author

@Bartvds Any chance you can investigate Bartvds/tslint-path-formatter#4 ? This update to grunt-ts is now blocked by the bug it fixes. I'm willing to do it if you give me permissions to the repo.

@basarat
Copy link
Member

basarat commented Mar 10, 2015

It's just the transform problem that I am scratching my head on.

The diff does contain changes to transformers.ts : https://github.com/TypeStrong/grunt-ts/pull/215/files I would start with reverting those if those were not intentional ❤️

nycdotnet added a commit that referenced this pull request Mar 27, 2015
Merge PR #215 - Implement Visual Studio Project support
@nycdotnet nycdotnet merged commit 00f0f84 into master Mar 27, 2015
@nycdotnet nycdotnet deleted the implement-VSPROJ-support branch March 27, 2015 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants