Skip to content

Interface change doesn't trigger change in webpack #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andreyctkn opened this issue Feb 16, 2016 · 7 comments · Fixed by #169
Closed

Interface change doesn't trigger change in webpack #156

andreyctkn opened this issue Feb 16, 2016 · 7 comments · Fixed by #169

Comments

@andreyctkn
Copy link

For example:

  1. clone this starter kit https://github.com/AndreyUtka/angular-typescript-starter-kit
  2. run web pack dev server
  3. Make some change in interface
export interface IHelloScope {
    displayName: string;
    style: Object;
}

->

export interface IHelloScope {
    displayName: boolean;
    style: Object;
}

In this case, it does not trigger update process.

The main question is why it does not trigger an update when I made changes only in interfaces?

Thanks.

@kpesanka
Copy link

I am experiencing the same issue as well (interface changes not triggering webpack) with a different starter kit:

https://github.com/preboot/angular2-webpack

@jbrantly
Copy link
Member

jbrantly commented Mar 4, 2016

@chadaustin reported an issue via twitter that I believe is related: https://twitter.com/chadaustin/status/705542582189715456

Sorry for the delay on this. I'm planning on taking a look this weekend.

@johnnyreilly
Copy link
Member

I think I may be experiencing this too but I'm not sure. Certainly I'm breaking things, fixing them and then having to re-kick off my watcher. No great hardship but it would be nice if I didn't have to do that every now and then.

@jbrantly
Copy link
Member

jbrantly commented Mar 4, 2016

There's a test for this kind of thing at https://github.com/TypeStrong/ts-loader/tree/master/test/typeSystemWatch but there must be some case that is being missed.

@raybooysen
Copy link

Interesting, I see the same thing. Often the loader will stop seeing
changes to files, especially after you wrote bad code and there were
errors. I have to restart webpack to get it going again. Guess it's time
to build a specific test.

On 4 March 2016 at 15:08, James Brantly notifications@github.com wrote:

There's a test for this kind of thing at
https://github.com/TypeStrong/ts-loader/tree/master/test/typeSystemWatch
but there must be some case that is being missed.


Reply to this email directly or view it on GitHub
#156 (comment)
.

@andreyctkn
Copy link
Author

I've tried https://www.npmjs.com/package/awesome-typescript-loader and it handles this case perfectly

jbrantly added a commit that referenced this issue Apr 11, 2016
* Watch for changes on elided imports. (#156)

* Fix bug and update tests
@jbrantly
Copy link
Member

Released in v0.8.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants