Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track timestamps to filter changed files. #500

Merged
merged 2 commits into from
Mar 16, 2017

Conversation

WearyMonkey
Copy link
Contributor

getTimes() returns a map with all files. This breaks version tracking as all file versions are incremented.

This PR adds manual timestamp tracking to filter out actually changed files.

@johnnyreilly
Copy link
Member

Thanks! Let's see how the tests do. Also @jbrantly would you be able to comment on this? Seems like a reasonable change to me.

@WearyMonkey I'm probably about to go offline - ping me tomorrow if it looks like I've forgotten about this.

@johnnyreilly
Copy link
Member

Okay the failing tests are issue441 and importsWatch - i think the failures are reasonable and expected given the changed behaviour this will introduce. Do you want to regenerate the 2.2 test output for these tests? You might need to delete the existing output manually before you do this; it doesn't always clean up entirely. If memory serves you'll need to do something like npm run comparison-tests -- --save-output --single-test issue441 etc

@johnnyreilly
Copy link
Member

Just had a go at regenerating the test data myself. I didn't realise I could work directly on a supplied PR before I'd landed it. Pleased to see I can 😄

@johnnyreilly johnnyreilly merged commit 44a2cdb into TypeStrong:master Mar 16, 2017
@johnnyreilly
Copy link
Member

Merged - will look to cut a release tonight if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants