v8.6.0 breaks TS_NODE_COMPILER_OPTIONS environment variable

[dstaley]

The release of v8.6.0 introduced the ability to configure via tsconfig.json. However, it looks like in the process the ability to use TS_NODE_COMPILER_OPTIONS was either removed or broken, resulting in broken builds for us.

Since v8.6.0 was a minor semver release and did not have a "Breaking Changes" section in the release notes, I did not anticipate any breaking changes in this release. If the change was intentional, I suggest adding a "Breaking Changes" section to the release notes, otherwise a patch release that restores the behavior would be appreciated! In the meantime I've moved to using tsconfig.json, so this would just be for other users who find themselves in the same situation I found myself in.

[cspotcode]

Do you have a minimal reproducible example of the bug, to help with diagnosis? This is not intended to be a breaking change, hence the minor version bump. Affected users can continue using the previous version of ts-node in the meantime.

…

On Fri, Jan 10, 2020, 1:40 PM Dylan Staley ***@***.***> wrote: The release of v8.6.0 introduced the ability to configure via tsconfig.json. However, it looks like in the process the ability to use TS_NODE_COMPILER_OPTIONS was either removed or broken, resulting in broken builds for us. Since v8.6.0 was a minor semver release and did not have a "Breaking Changes" section in the release notes, I did not anticipate any breaking changes in this release. If the change was intentional, I suggest adding a "Breaking Changes" section to the release notes, otherwise a patch release that restores the behavior would be appreciated! In the meantime I've moved to using tsconfig.json, so this would just be for other users who find themselves in the same situation I found myself in. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#938?email_source=notifications&email_token=AAC35OFPXW2ENQ3762XGUBLQ5C6K5A5CNFSM4KFLXXGKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IFNLELQ>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAC35OEILFUZI5ZWJLZEUG3Q5C6K5ANCNFSM4KFLXXGA> .

[dstaley]

Sure thing! Here you go.

[blakeembrey]

Thanks for the report, I think I may have introduced it when refactoring the tsconfig.json support. Revising the logic now.

[cspotcode]

DEFAULTS.compilerOptions should store the value parsed from the environment variable.
https://github.com/TypeStrong/ts-node/blob/master/src/index.ts#L242

readConfig pulls from DEFAULTS when building the merged compilerOptions object.
https://github.com/TypeStrong/ts-node/blob/master/src/index.ts#L909-L916

Shouldn't that be correctly incorporating the environment variable?

[cspotcode]

Oh I think it's because of the ordering of overrides.

I put the 2 indicated values out of order. (from here)

config.compilerOptions = Object.assign(
    {},
    DEFAULTS.compilerOptions,  // <-- the env var
    config.compilerOptions, // <-- the tsconfig's "compilerOptions"
    config['ts-node']?.compilerOptions,
    options.compilerOptions,
    TS_NODE_COMPILER_OPTIONS
  )

[blakeembrey]

Fixed with db409d7 and release as V8.6.1 - thanks!