Run tests e2e against an npm pack && npm installed ts-node
#1032
Conversation
| await execP(`npm install`, { cwd: TEST_DIR }) | ||
| const packageLockPath = join(TEST_DIR, 'package-lock.json') | ||
| existsSync(packageLockPath) && unlinkSync(packageLockPath) | ||
| }) |
There was a problem hiding this comment.
I wonder if these a way to do this outside of the test suite or possibly a separate set of tests? Either way this looks like a great start at coverage.
There was a problem hiding this comment.
I can definitely move the npm pack into our npm build. That would be better since it would npm pack using the same node and npm versions as we use to publish.
Are you thinking you want 2x sets of tests, one unit tests, the other doing these e2e-style tests against an npm install?
I thought about that but I wasn't sure how useful it'd be since the tests mostly look e2e-style already. Your call though, happy to split things out.
There was a problem hiding this comment.
Let's keep it how it is then, I don't have strong opinions either way but it's great to know you thought about this.
|
@blakeembrey This is ready for (one more) review. I moved the Here are the changes since your last review to make it a little easier. |
This is necessary to test that our entrypoints are working correctly with package.json "exports".
This change runs
npm packto create a tarball, thennpm installs it intotests/node_modules/The tests
require('ts-node/register')and exec./node_modules/.bin/ts-nodeso it matches how a consumer invokests-node.