Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coverage reporting when tests fail; also push to codecov #1047

Merged
merged 10 commits into from
May 18, 2020

Conversation

cspotcode
Copy link
Collaborator

@cspotcode cspotcode commented May 17, 2020

codecov has path rewriting built-in so we do not need a custom ./scripts/rewrite-coverage-paths.js.

It might not exhibit the weird issues I'm seeing with coveralls' Github Actions integration.

Merging to master so we can get some coverage data from master into Codecov and see if it behaves nicely on pull requests.

@codecov-io
Copy link

codecov-io commented May 17, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@9840cb1). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1047   +/-   ##
=========================================
  Coverage          ?   73.57%           
=========================================
  Files             ?        4           
  Lines             ?      507           
  Branches          ?      130           
=========================================
  Hits              ?      373           
  Misses            ?       83           
  Partials          ?       51           
Flag Coverage Δ
#node_10 71.59% <0.00%> (?)
#node_12 71.99% <0.00%> (?)
#node_13 73.37% <0.00%> (?)
#node_14 73.37% <0.00%> (?)
#typescript_2_7 72.97% <0.00%> (?)
#typescript_latest 72.18% <0.00%> (?)
#typescript_next 71.99% <0.00%> (?)
#ubuntu 73.37% <0.00%> (?)
#windows 73.37% <0.00%> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9840cb1...4086680. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.2%) to 81.743% when pulling c6b4eef on ab/fix-coverage-when-tests-fail into 9840cb1 on master.

@coveralls
Copy link

coveralls commented May 17, 2020

Coverage Status

Coverage remained the same at 82.988% when pulling 4086680 on ab/fix-coverage-when-tests-fail into 9840cb1 on master.

@cspotcode cspotcode marked this pull request as ready for review May 18, 2020 04:58
@cspotcode cspotcode merged commit 196aafb into master May 18, 2020
@cspotcode cspotcode deleted the ab/fix-coverage-when-tests-fail branch August 12, 2020 18:23
@cspotcode cspotcode mentioned this pull request Aug 21, 2020
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants