-
-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update version checks for v16 #1522
Conversation
Should be 16.12.0, right? Can we also add 16.11.0 to our test matrix, so that we are certain to test against 2x 16.x versions: one before the loader hooks changed, and one after? |
Yes, Sure will try to add tests today. |
@cspotcode #1007 needs to update to reflect the exact version number. |
Thanks, I updated it under "node's API change: v16.12.0, v17.0.0" |
Codecov Report
|
@shrujalshah28 thank you! |
Ref: nodejs/node#40504