when calling default* functions, you should not recursively pass default* function #1849
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the documentation (https://nodejs.org/api/esm.html#loaders), when calling
nextResolve
and
nextLoad
, one should not pass thenext*
function again to itself.This causes a problem when using multiple loaders, as evidenced by this issue: testdouble/testdouble.js#496.
Two notes:
in the reproduction, when I removed ts-node's recursive call, everything worked.
defaultResolve/load
signature is not the same asresolve/load
-s,I made it
any
. Any other try created errors in other places. Sorry, I'm not a TS expert.