-
-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add @tsconfig/node20, add node 20 to test matrix #2003
Conversation
Does this fix #1997 (the ESM support in Node 20) , @chentsulin ? |
+1 Bump |
@@ -87,10 +87,21 @@ jobs: | |||
nodeFlag: 18 | |||
typescript: next | |||
typescriptFlag: next | |||
# Node nightly | |||
# Node 20 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also need to add to flavor
array above
node: 20 | ||
nodeFlag: 20 | ||
typescript: next | ||
typescriptFlag: next |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove this one; I'm trying to keep only a single entry for typescript@next. I suspect that github actions throttle if you use it too much, so I try to keep the test matrix small where possible.
I renamed this PR to clarify that it does not add support for node 20, it only adds the @tsconfig/bases for node 20. |
Codecov Report
|
@cspotcode So when will ts-node support node v20, my projects are currently in a standstill due to this |
CI is showing "Error: Unable to find Node version 'nightly' for platform linux and architecture x64." The version was |
Should there be a release newer than a year ago that makes mention of Node20? |
Add @tsconfig/node20, add node 20 to test matrix.