Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @tsconfig/node20, add node 20 to test matrix #2003

Merged
merged 4 commits into from
May 31, 2023

Conversation

chentsulin
Copy link
Contributor

@chentsulin chentsulin commented Apr 28, 2023

Add @tsconfig/node20, add node 20 to test matrix.

@RobinTail
Copy link

RobinTail commented May 1, 2023

Does this fix #1997 (the ESM support in Node 20) , @chentsulin ?

@r-rajaneesh
Copy link

+1 Bump

@cspotcode cspotcode changed the title Support Node 20 Add @tsconfig/node20, add node 20 to test matrix May 7, 2023
@@ -87,10 +87,21 @@ jobs:
nodeFlag: 18
typescript: next
typescriptFlag: next
# Node nightly
# Node 20
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also need to add to flavor array above

node: 20
nodeFlag: 20
typescript: next
typescriptFlag: next
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove this one; I'm trying to keep only a single entry for typescript@next. I suspect that github actions throttle if you use it too much, so I try to keep the test matrix small where possible.

@cspotcode
Copy link
Collaborator

I renamed this PR to clarify that it does not add support for node 20, it only adds the @tsconfig/bases for node 20.

@codecov
Copy link

codecov bot commented May 7, 2023

Codecov Report

Merging #2003 (4f4369c) into main (7af5c48) will increase coverage by 0.01%.
The diff coverage is 66.66%.

Impacted Files Coverage Δ
src/tsconfigs.ts 81.25% <66.66%> (-3.37%) ⬇️

... and 1 file with indirect coverage changes

@r-rajaneesh
Copy link

@cspotcode So when will ts-node support node v20, my projects are currently in a standstill due to this

@cspotcode
Copy link
Collaborator

CI is showing "Error: Unable to find Node version 'nightly' for platform linux and architecture x64."
https://github.com/TypeStrong/ts-node/actions/runs/4972785977/jobs/9240373078?pr=2003

The version was 20-nightly and this PR changes it to nightly. Perhaps it should be changed back?

@cspotcode cspotcode merged commit 47d4f45 into TypeStrong:main May 31, 2023
@chentsulin chentsulin deleted the feat/node20 branch June 1, 2023 03:12
@OneCricketeer
Copy link

OneCricketeer commented Jul 24, 2023

Should there be a release newer than a year ago that makes mention of Node20?

https://github.com/TypeStrong/ts-node/releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants