Normalize slashes for windows paths #285
Conversation
src/index.ts
Outdated
| @@ -574,6 +574,7 @@ export function fileExists (fileName: string): boolean { | |||
| * Get directories within a directory. | |||
| */ | |||
| export function getDirectories (path: string): string[] { | |||
| console.log(`getDirectories: ${path}`) | |||
There was a problem hiding this comment.
Need to remove the console.log from here.
src/index.ts
Outdated
| @@ -445,14 +445,14 @@ function readConfig (compilerOptions: any, project: string | boolean | undefined | |||
| delete result.config.compilerOptions.outFile | |||
| delete result.config.compilerOptions.declarationDir | |||
|
|
|||
| const basePath = result.path ? dirname(result.path) : cwd | |||
| const basePath = result.path ? normalizeSlashes(dirname(result.path)) : cwd | |||
There was a problem hiding this comment.
It looks like you should be normalizing the slashes on both sides, not just the left side of the ternary.
There was a problem hiding this comment.
Fixed. Interesting note is that without a tsconfig.json this problem did not exists for me. But as soon as i added a tsconfig.json i got the error. It seems that typescript handles basePath differently as cwd also uses the windows path separator. Any how the less confusing way would be to treat them the same as you said.
src/index.ts
Outdated
| @@ -445,14 +445,15 @@ function readConfig (compilerOptions: any, project: string | boolean | undefined | |||
| delete result.config.compilerOptions.outFile | |||
| delete result.config.compilerOptions.declarationDir | |||
|
|
|||
| const basePath = result.path ? dirname(result.path) : cwd | |||
| const normalizedConfigPath = result.path && normalizeSlashes(result.path) | |||
There was a problem hiding this comment.
I realized we need to handle when no tsconfig.json is found. Can't do replace on undefined. So fixed that to.
|
@Jontem thanks for picking this up! 👍 |
This PR solves the problem discussed in #283 and should also solve #216. I've only tested on a minimal repro on windows. There already was a function named
slashthat was exactly implemented asnormalizeSlashesthat typecript exports. So i just used that one.