Add timestamp to debug logging #994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cspotcode
requested changes
Apr 2, 2020
src/index.ts
Outdated
| const timestamp = function(){}; | ||
| timestamp.toString = function(){ | ||
| return "[ts-node " + (new Date).toISOString() + "]"; | ||
| } |
There was a problem hiding this comment.
This looks unnecessarily clever. Let's keep it simple and call the function every time we need a timestamp. function timestamp() {return "ts-node ...
src/index.ts
Outdated
| timestamp.toString = function(){ | ||
| return "[ts-node " + (new Date).toISOString() + "]"; | ||
| } | ||
| const debug = shouldDebug ? console.log.bind(console, '%s', timestamp) : () => undefined |
There was a problem hiding this comment.
IMO we should simplifying by writing a function.
function(...args) {console.log(timestamp(), ...args)}
|
I now actioned your comments. |
cspotcode
requested changes
Apr 3, 2020
src/index.ts
Outdated
| @@ -38,7 +38,9 @@ function yn (value: string | undefined) { | |||
| * Debugging `ts-node`. | |||
| */ | |||
| const shouldDebug = yn(process.env.TS_NODE_DEBUG) | |||
| const debug = shouldDebug ? console.log.bind(console, 'ts-node') : () => undefined | |||
| const debug = shouldDebug ? | |||
| (...args: any) => console.log(`ts-node ${new Date().toISOString()}`, ...args) | |||
There was a problem hiding this comment.
Square brackets need to be re-added. Otherwise looks good.
This was referenced Apr 23, 2020
This was referenced Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add timestamp for debug logging.
example output is
Associated with #754 (comment)