Skip to content

Commit

Permalink
Disregard compilerOptions.noEmit (#144)
Browse files Browse the repository at this point in the history
  • Loading branch information
danielmoore authored and blakeembrey committed Jul 1, 2016
1 parent 85ae97f commit 97eaeec
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ For use on the command line, use the flag `npm install -g`.
tsify will automatically read options from `tsconfig.json`. However, some options from this file will be ignored:

* `compilerOptions.declaration` - See [tsify#15](https://github.com/TypeStrong/tsify/issues/15)
* `compilerOptions.out` and `compilerOptions.outDir` - Use Browserify's file output options instead. These options are overridden because **tsify** writes its intermediate JavaScript output to an internal memory store instead of to the filesystem.
* `compilerOptions.out`, `compilerOptions.outDir`, and `compilerOptions.noEmit` - Use Browserify's file output options instead. These options are overridden because **tsify** writes its intermediate JavaScript output to an internal memory store instead of to the filesystem.
* `files` - Use Browserify's file input options instead. This is necessary because Browserify needs to know which file(s) are the entry points to your program.

### Watchify?
Expand Down
3 changes: 2 additions & 1 deletion lib/Tsifier.js
Original file line number Diff line number Diff line change
Expand Up @@ -82,10 +82,11 @@ module.exports = function (ts) {
// Default to CommonJS module mode
parsed.options.module = parsed.options.module || ts.ModuleKind.CommonJS;

// Blacklist --out/--outFile; these should definitely not be set, since we are doing
// Blacklist --out/--outFile/--noEmit; these should definitely not be set, since we are doing
// concatenation with Browserify instead
delete parsed.options.out;
delete parsed.options.outFile;
delete parsed.options.noEmit;

// Set rootDir and outDir so we know exactly where the TS compiler will be trying to
// write files; the filenames will end up being the keys into our in-memory store.
Expand Down

0 comments on commit 97eaeec

Please sign in to comment.