Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move typescript as a dev dependency #153

Closed
basarat opened this issue Jul 7, 2016 · 5 comments · Fixed by #154
Closed

Move typescript as a dev dependency #153

basarat opened this issue Jul 7, 2016 · 5 comments · Fixed by #154
Assignees

Comments

@basarat
Copy link
Member

basarat commented Jul 7, 2016

Its been raised before : #85 Moving it to a dev dependency is what ts-loader does : https://github.com/TypeStrong/ts-loader/blob/master/package.json#L47 Mind if I do the same here.

This will greatly help me in migrating babel/babelify projects to TypeScript. The projects I am migrating all use only npm scripts so I can't use the plugin api with require('typescript') to override the version 🌹

/cc @smrq sorry for the hard direct mention 🌹

@blakeembrey
Copy link
Member

Agreed @basarat 👍 We should work on making all the loaders BYOT (bring your own TypeScript) so people can upgrade independently.

@basarat
Copy link
Member Author

basarat commented Jul 7, 2016

Can I has npm access please 🐱

@basarat basarat self-assigned this Jul 7, 2016
@blakeembrey
Copy link
Member

blakeembrey commented Jul 7, 2016

Ah, I didn't see I had gotten access. Awesome 😄

Edit: Done.

@smrq
Copy link
Member

smrq commented Jul 7, 2016

Thanks for taking care of all this stuff guys!

On Thu, Jul 7, 2016, 1:41 PM Blake Embrey notifications@github.com wrote:

Ah, I didn't see I had gotten access. Awesome 😄


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#153 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAYd-WCESI0o1ILNhG7dVNBrFo003gJ1ks5qTUg-gaJpZM4JGwZl
.

@basarat
Copy link
Member Author

basarat commented Jul 7, 2016

Mind if I deploy this as 1.0.0. Basically increment the major version as this is a breaking change as the users now need to npm install typescript@whatever-version-they-want as well 🌹

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants