Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Called normalizeSlashes in getDefaultLibFileName #197

Merged
merged 1 commit into from
Sep 9, 2016

Conversation

cartant
Copy link
Contributor

@cartant cartant commented Sep 9, 2016

Without this TypeScript 2 breaks when trying to determine the location of the lib directory on Windows.

@cartant cartant merged commit 1c1942f into TypeStrong:master Sep 9, 2016
@@ -104,7 +104,7 @@ module.exports = function (ts) {
Host.prototype.getDefaultLibFileName = function () {
var libPath = path.dirname(ts.sys.getExecutingFilePath());
var libFile = ts.getDefaultLibFileName({ target: this.languageVersion });
return path.join(libPath, libFile);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nycdotnet
Copy link

Seems old Bas has finally lost it completely. ;-) Thanks for the PR @cartant!

@johnnyreilly
Copy link
Member

Ha!

@cartant cartant deleted the issue-196 branch October 3, 2016 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants