Fix double link resolution in packages/merge mode

Resolves #2680
TypeStrong · Aug 21, 2024 · ea0ea91 · ea0ea91
1 parent f0f3d96
commit ea0ea91
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Unreleased
 
+### Bug Fixes
+
+- Fixed an issue where links in packages mode would be resolved incorrectly, #2680.
+
 ## v0.26.6 (2024-08-18)
 
 ### Features

diff --git a/src/lib/converter/comments/linkResolver.ts b/src/lib/converter/comments/linkResolver.ts
@@ -4,7 +4,7 @@ import {
  type CommentDisplayPart,
  DeclarationReflection,
  type InlineTagDisplayPart,
- type Reflection,
+ Reflection,
  ReflectionSymbolId,
 } from "../../models";
 import {
@@ -112,6 +112,12 @@ function resolveLinkTag(
  externalResolver: ExternalSymbolResolver,
  options: LinkResolverOptions,
 ): InlineTagDisplayPart {
+ // This tag may have already been resolved to if we are running in packages mode
+ // or when reading in a JSON file. #2680.
+ if (typeof part.target === "string" || part.target instanceof Reflection) {
+ return part;
+ }
+
  let defaultDisplayText = "";
  let pos = 0;
  const end = part.text.length;