-
Notifications
You must be signed in to change notification settings - Fork 700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugins: Icons invisible when a large script is added on head.end
#2589
Comments
To provide additional details, I have a custom TypeDoc theme that uses a renderer.hooks.on('head.end', (_event) => {
return (
// This happens with different libraries:
//<script src="https://cdn.jsdelivr.net/npm/js-draw@1.20.3/dist/bundle.js" integrity="sha256-XJN7539P8FaFEZDXUEgMlp9ERBdhME2Gk7EoSZN2v3I=" crossOrigin="anonymous"></script>
<script src="https://code.jquery.com/jquery-3.7.1.js" integrity="sha256-eKhayi8LEQwp4NKxN+CfCh+3qOVUtJn3QNZ0TciWLP4=" crossOrigin="anonymous"></script>
);
}); For reference, (Thank you for this excellent project!) |
personalizedrefrigerator
added a commit
to personalizedrefrigerator/js-draw
that referenced
this issue
Jun 11, 2024
This reverts commit 7304e86. Blocked by TypeStrong/typedoc#2589.
Gerrit0
added a commit
that referenced
this issue
Jun 11, 2024
Oops, that's busted... at least it's an easy fix! |
Fixed with 0.26, which is releasing 2024/06/21 |
This was referenced Jul 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Search terms
script, defer, svg, head.end, body.begin, plugin, theme
Expected Behavior
The size of a script included in
head.end
should not affect whether icons are visible.Actual Behavior
Large scripts cause most icons (dropdown icons, etc.) to be invisible. Adding
defer
to the script helps, but the icons are still sometimes invisible.Steps to reproduce the bug
A minimal sample project with the issue can be found here.
More specifically,
typedoc/bug-include-script
branch.npm i
npm run build
npm run doc
cd docs && python3 -m http.server
.Environment
The text was updated successfully, but these errors were encountered: