Improve readability of source code #1889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No need to hand-roll this anymore.
`reflection.name === ""` won't match if `!reflection.name` is checked above.
Gerrit0
requested changes
Mar 20, 2022
|
Ignore the CI failure for visual regression, not caused by your changes. |
fb55
added a commit
to fb55/typedoc
that referenced
this pull request
Mar 22, 2022
Similar to TypeStrong#1889 — improves some code to make it more readable.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently ran into #1606 (see inikulin/parse5#467). I spent a couple of hours trying to understand the source code of TypeDoc, and made small changes whenever it took me longer to understand a piece of code than it should have. The commits should be helpful as a description of why things were changed.
I've targeted the
betabranch — hope this is where commits should be added.