fix(fs): glob will traverse node_modules if asked to #2164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the `pattern` passed to `glob()` contains `node_modules`, then `node_modules` will be traversed. This is _naive_ in that it does not care about the _context_ of `node_modules` in the pattern; it could be a negation, or whatever (e.g., some passes `!**/node_modules/**`). However, `minimatch` should still do its thing, so hopefully this won't be too bad.
|
@Dayday10 I don't see any suggested changes..? weird. |
Gerrit0
approved these changes
Feb 9, 2023
|
Thanks! Should get released today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
patternpassed toglob()containsnode_modules, thennode_moduleswill be traversed.This is naive in that it does not care about the context of
node_modulesin the pattern; it could be a negation, or whatever (e.g., some passes!**/node_modules/**). However,minimatchshould still do its thing, so hopefully this won't be too bad.Closes #2151