Skip to content

fix(createNormalizedUrl): replace String.fromCharCode by String.fromCodePoint #2906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 19, 2025

Conversation

romainmnr
Copy link
Contributor

@Gerrit0
Copy link
Collaborator

Gerrit0 commented Mar 18, 2025

Please add a test which demonstrates why the fix is necessary so that it isn't broken in the future

@romainmnr
Copy link
Contributor Author

I'm facing an issue install the dependencies:
pnpm install:

Lockfile is up to date, resolution step is skipped
Packages: +284
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Packages are cloned from the content-addressable store to the virtual store.
  Content-addressable store is at: /Users/romain/Library/pnpm/store/v10
  Virtual store is at:             node_modules/.pnpm
../../../../Library/pnpm/store/v10/tmp/_tmp_73656_1a31e7e1648f2980d9b5200af333a88c [@typestrong/fs-fixture-builder@0.0.0]: Running yarn-install script...
 ERR_PNPM_PREPARE_PACKAGE  Failed to prepare git-hosted package fetched from "https://codeload.github.com/TypeStrong/fs-fixture-builder/tar.gz/34113409e3a171e68ce5e2b55461ef5c35591cfe": @typestrong/fs-fixture-builder@0.0.0 yarn-install: `yarn install`@dprint/darwin-arm64@0.49.0: 759.00 B/7.90 MB
spawn ENOENT
Progress: resolved 284, reused 281, downloaded 1, added 0
Downloading @dprint/darwin-arm64@0.49.0: 759.00 B/7.90 MB

@romainmnr
Copy link
Contributor Author

I'm facing an issue install the dependencies: pnpm install:

Lockfile is up to date, resolution step is skipped
Packages: +284
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Packages are cloned from the content-addressable store to the virtual store.
  Content-addressable store is at: /Users/romain/Library/pnpm/store/v10
  Virtual store is at:             node_modules/.pnpm
../../../../Library/pnpm/store/v10/tmp/_tmp_73656_1a31e7e1648f2980d9b5200af333a88c [@typestrong/fs-fixture-builder@0.0.0]: Running yarn-install script...
 ERR_PNPM_PREPARE_PACKAGE  Failed to prepare git-hosted package fetched from "https://codeload.github.com/TypeStrong/fs-fixture-builder/tar.gz/34113409e3a171e68ce5e2b55461ef5c35591cfe": @typestrong/fs-fixture-builder@0.0.0 yarn-install: `yarn install`@dprint/darwin-arm64@0.49.0: 759.00 B/7.90 MB
spawn ENOENT
Progress: resolved 284, reused 281, downloaded 1, added 0
Downloading @dprint/darwin-arm64@0.49.0: 759.00 B/7.90 MB

I found a workaround using npm instead of pnpm....

@Gerrit0 Gerrit0 merged commit 2d95afa into TypeStrong:master Mar 19, 2025
8 checks passed
@Gerrit0
Copy link
Collaborator

Gerrit0 commented Mar 19, 2025

Strange... some MacOS thing? Thanks for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants